Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vizarr visualization #19061

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Oct 25, 2024

Requires #19040 and #19097
xref #16862

Visualization for Zarr-like datasets based on https://github.com/hms-dbmi/vizarr

For local Zarr datasets (directories uploaded as zip)

Screencast.from.2024-10-25.17-15-38.mp4

For remote (deferred) Zarr datasets (URI pointing to an S3 or remote location)

VisualizeDeferredZarr.mp4

TODO

  • Move the visualization to the new "pre-built visualizations" best practice
  • Fix ZarrDirectory datatype not being associated with the visualization (all the other datatypes work...)

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • Using local Zarr datasets
      • Upload a zarr.zip or ome_zarr.zip file with image data
      • Unpack the zip to a directory using the appropriate datatype converter
      • Check the Vizarr visualization
    • Using remote Zarr datasets (public)
      • Go to a public Zarr repository, for example, https://www.openmicroscopy.org/2020/11/04/zarr-data.html
      • Copy any link to a zarr-based store and paste it into the Galaxy upload dialog
      • Make sure you set defer dataset resolution in the upload options before uploading
      • Once it is uploaded, check the Vizarr visualization for the deferred dataset

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bgruening
Copy link
Member

@davelopez is that one ready to go? If so can you please take it out of Draft?

@davelopez
Copy link
Contributor Author

@bgruening it is technically ready, but I want to make sure I follow the latest changes in the instructions for creating new visualizations and I'm currently publishing the package to npm with my own account, I think the decision was to publish all of them under galaxyproject, so I need to make sure.
I will take a look today 👍

@davelopez davelopez marked this pull request as ready for review November 13, 2024 16:49
Copy link
Contributor

@guerler guerler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@guerler guerler merged commit 07290ad into galaxyproject:dev Nov 13, 2024
42 of 44 checks passed
@github-actions github-actions bot added this to the 25.0 milestone Nov 13, 2024
@davelopez davelopez deleted the add_vizarr_visualization branch November 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants