Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TRS import into WorkflowContentManager #19070

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Move TRS import into WorkflowContentManager #19070

merged 1 commit into from
Oct 30, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 28, 2024

which fixes missing source metadata when importing a workflow through a landing page.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek added kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes area/workflows labels Oct 28, 2024
@github-actions github-actions bot added this to the 24.2 milestone Oct 28, 2024
@mvdbeek mvdbeek force-pushed the reuse_trs_import_in_workflow_contents_manager branch 2 times, most recently from c28b591 to 2b4ec7f Compare October 30, 2024 11:27
jmchilton
jmchilton approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting and API errors look legit but the concept is all good to me. I'm +1 once it is greener.

@mvdbeek mvdbeek force-pushed the reuse_trs_import_in_workflow_contents_manager branch from 2b4ec7f to 457a084 Compare October 30, 2024 16:01
@mvdbeek
Move TRS import into WorkflowContentManager
48ed068 
which fixes missing source metadata when importing a workflow through a
landing page.
@mvdbeek mvdbeek force-pushed the reuse_trs_import_in_workflow_contents_manager branch from 457a084 to 48ed068 Compare October 30, 2024 16:32
@mvdbeek mvdbeek merged commit 339724e into galaxyproject:dev Oct 30, 2024
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/workflows kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdbeek @jmchilton