Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lock.json #20

Closed
wants to merge 1 commit into from

Conversation

kysrpex
Copy link

@kysrpex kysrpex commented Jun 19, 2024

Hello! I was attempting to work with this code and found difficulties because some developer dependencies' versions are not declared with enough precision. To be specific, I could not run the tests.

After changing the contents of package.json to the following

[...]
  "devDependencies": {
    "axios": "*",
    "axios-retry": "^3",
    "chai": "^4",
    "eslint": "^8.3.0",
    "eslint-config-strongloop": "^2.1.0",
    "mocha": "*",
    "prettier": "^3.0.3"
  }
[...]

and running npm install I arrived at this package-lock.json, for which all scripts work: npm run test, npm run lint, npm run format and npm run format-check.

I wanted to contribute the file upstream so that anyone else that wants to work with the project's code does not have to repeat this step.

Pin project dependencies to a set for which tests pass using package-lock.json.
Comment on lines +22 to +30
"devDependencies": {
"axios": "*",
"axios-retry": "*",
"chai": "*",
"eslint": "^8.3.0",
"eslint-config-strongloop": "^2.1.0",
"mocha": "*",
"prettier": "^3.0.3"
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I have reverted axios-retry and chai to "*". This does not break the file, it will still work. You may consider adding the version specifiers I mention in the PR's description to package.json, and it may help even further to work out what version specifiers are adequate for axios and mocha.

@bgruening
Copy link
Member

Can this one now be closed with the other one open?

@kysrpex
Copy link
Author

kysrpex commented Jul 9, 2024

Yes, #21 includes a package-lock.json file too, so this one can be closed.

@kysrpex kysrpex closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants