-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clinicalmp-quantitation workflow #505
Conversation
Test Results (powered by Planemo)Test Summary
Errored Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks very promising so far, thanks a lot @subinamehta!
workflows/proteomics/clinicalmp/clinicalmp-quantitation/iwc-clinicalmp-quantitation.ga
Outdated
Show resolved
Hide resolved
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
Could we please take a look at this pull request? |
Sure, could you delete the .DS_Store files and move the test data to zenodo ? The test run took 3 hours, do you see a way to make the tests run a little faster ? Perhaps by reducing the input data size ? |
I see you've moved the test data to zenodo, but it's still included here, can you also delete those files ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super nice. Let me know if it's not feasible to reduce the test runtime, it would be better if we can test this quicker but if not this is also OK.
workflows/proteomics/clinicalmp/clinicalmp-quantitation/iwc-clinicalmp-quantitation.ga
Outdated
Show resolved
Hide resolved
workflows/proteomics/clinicalmp/clinicalmp-quantitation/iwc-clinicalmp-quantitation.ga
Show resolved
Hide resolved
workflows/proteomics/clinicalmp/clinicalmp-quantitation/iwc-clinicalmp-quantitation.ga
Outdated
Show resolved
Hide resolved
I think I resolved all the issues now! |
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
Could you tell me what this chunked test error is saying? |
We're also running out of disk space, is there any way those test files could be made smaller ? |
Let me see if for the workflow purpose to use just one file. Will that work?
*Subina Mehta*
Researcher, Dept. of Biochemistry, Molecular Biology and Biophysics
Bioinformatics Specialist, Proteogenomics Shared Resource, Masonic Cancer
Center
University of Minnesota
7-166 MCB
420 Washington Ave SE
Minneapolis, MN 55455
Lab: 612-624-0381
Phone: 612-500-8841
Email: ***@***.*** ***@***.***>*
*www.galaxyp.org* <http://www.galaxyp.org/>
http://z.umn.edu/itcrgalaxyvideo
…On Mon, Sep 2, 2024 at 10:41 AM Marius van den Beek < ***@***.***> wrote:
We're also running out of disk space, is there any way those test files
could be made smaller ?
—
Reply to this email directly, view it on GitHub
<#505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGP3A7LLYP6Z2PCUNXLJAHLZUR2KFAVCNFSM6AAAAABMQTLKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHEYDKMBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
workflows/proteomics/clinicalmp/clinicalmp-quantitation/iwc-clinicalmp-quantitation.ga
Show resolved
Hide resolved
I think the number of files doesn't matter, it's the total size that is the limit currently.
The file causing it is https://zenodo.org/records/13505774/files/191023JAT11_3_Mix_1_1ug_pOT_30k_390_1010_12_20.raw which is 1.6GB in size. |
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
could we please merge this? |
@mvdbeek : could we merge this into the IWC, we have a workshop coming up next week and we would like to portray this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I would still suggest to improve the step labels a little, but we can do that in a followup.
WIP-Adding a workflow under IWC