Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating workflows/transcriptomics/rnaseq-sr from 0.4 to 0.5 #186

Conversation

planemo-autoupdate
Copy link
Contributor

Hello! This is an automated update of the following workflow: workflows/transcriptomics/rnaseq-sr. I created this PR because I think one or more of the component tools are out of date, i.e. there is a newer version available on the ToolShed.

By comparing with the latest versions available on the ToolShed, it seems the following tools are outdated:

  • toolshed.g2.bx.psu.edu/repos/iuc/rgrnastar/rna_star/2.7.8a+galaxy1 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/rgrnastar/rna_star/2.7.10b+galaxy2

The workflow release number has been updated from 0.4 to 0.5.

@lldelisle
Copy link
Contributor

Hi,
I have 2 issues with this PR:

  • In the CI, I get the following error:
Unexpected HTTP status code: 400: {"err_msg": "Workflow was not invoked; the following required tools are not installed: pick_value (version 0.1.0)", "err_code": 0, "traceback": "Traceback (most recent call last):\n  File \"/tmp/tmpte_429am/galaxy-dev/lib/galaxy/web/framework/decorators.py\", line 337, in decorator\n    rval = func(self, trans, *args, **kwargs)\n  File \"/tmp/tmpte_429am/galaxy-dev/lib/galaxy/webapps/galaxy/api/workflows.py\", line 751, in invoke\n    raise exceptions.MessageException(missing_tools_message)\ngalaxy.exceptions.MessageException: Workflow was not invoked; the following required tools are not installed: pick_value (version 0.1.0)\n"}

  • When I try the workflow on usegalaxy.org I have an issue: there are 2 subworkflows and only one of them should be run because they both have conditional and one is the contrary of the other. However, they both run... Any idea, why?
    Here is a 'simplified workflow':
    image

@mvdbeek
Copy link
Member

mvdbeek commented Aug 31, 2023

  • In the CI

that'll be fixed by galaxyproject/planemo#1385

Any idea, why?

No idea, I'll see what's up with that

@lldelisle
Copy link
Contributor

I can share the minimum workflow with you if you want.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 31, 2023

Ah yes, that would be helpful!

@lldelisle
Copy link
Contributor

It seems that there is still a bug. Let see that on Monday.

@mvdbeek
Copy link
Member

mvdbeek commented Sep 3, 2023

Ah, yes, a conditional workflow output, we missed that case!

@lldelisle lldelisle force-pushed the workflows/transcriptomics/rnaseq-sr branch from 81c76ff to 1a4bf91 Compare September 12, 2023 07:50
@lldelisle lldelisle force-pushed the workflows/transcriptomics/rnaseq-sr branch from 1a4bf91 to 5141c08 Compare September 12, 2023 08:01
@lldelisle
Copy link
Contributor

It finally passes 🎉 (I put all conditional steps to true)

@lldelisle lldelisle force-pushed the workflows/transcriptomics/rnaseq-sr branch from 3c1deb1 to 3457a62 Compare September 12, 2023 10:48
@lldelisle lldelisle requested a review from a team September 12, 2023 10:56
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you apply the same language edits from the PE PR ?

- `toolshed.g2.bx.psu.edu/repos/iuc/rgrnastar/rna_star/2.7.8a+galaxy1` was updated to `toolshed.g2.bx.psu.edu/repos/iuc/rgrnastar/rna_star/2.7.10b+galaxy4`

### Manual update
- Use STAR to compute normalized strand splitted coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Use STAR to compute normalized strand splitted coverage
- Use STAR to compute normalized strand-specific coverage


### Manual update
- Use STAR to compute normalized strand splitted coverage
- Propose StringTie to compute FPKM etc...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Propose StringTie to compute FPKM etc...
- Add option to use StringTie to compute FPKM

### Manual update
- Use STAR to compute normalized strand splitted coverage
- Propose StringTie to compute FPKM etc...
- Put cufflinks step optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Put cufflinks step optional
- Make cufflinks step optional

@lldelisle lldelisle mentioned this pull request Sep 15, 2023
@lldelisle
Copy link
Contributor

Thanks. I combined both in #211 (was easier for me to introduce spelling changes in both places)

@lldelisle lldelisle closed this Sep 15, 2023
@lldelisle lldelisle deleted the workflows/transcriptomics/rnaseq-sr branch September 27, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants