-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MGnify amplicon pipeline #343
base: main
Are you sure you want to change the base?
Conversation
Test Results (powered by Planemo)Test Summary
Errored Tests
❌ mgnify-amplicon-pipeline-quality-control-paired-end.ga_0Execution Problem:
Workflow invocation details
❌ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Execution Problem:
Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
❌ mgnify-amplicon-pipeline-quality-control-paired-end.ga_0Execution Problem:
❌ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Execution Problem:
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
❌ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Problems:
Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
❌ testing_query_tabular.ga_0Execution Problem:
Workflow invocation details
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
❌ testing_query_tabular.ga_0Problems:
Workflow invocation details
Passed Tests
|
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
✅ mgnify-amplicon-pipeline-quality-control-single-end.ga_0Workflow invocation details
|
I will try to review asap ! |
@@ -0,0 +1,17 @@ | |||
# MGnify's amplicon pipeline (v5.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is the main entry point for the user (or can there be a README for all workflows ? - then this would probably be better !)
Can we add:
- What it this? Can you add a few lines of explanation (what is MGnify, what is the amplicon pipeline, what is the advantage of this port, what do the individual workflows do ... )
- How can one test the workflow and see that the results are the same.
- Explain that the classification part is not the same due to mapseq (show example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should place this into the amplicon
folder after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And can you describe briefly how to only use parts of the workflow (just in short, the details come in the GTN)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from minor readme changes I think this is good to go. And failing tests ...
workflows/microbiome/mgnify-amplicon-taxonomic-summary-tables/README.md
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,17 @@ | |||
# MGnify's amplicon pipeline (v5.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And can you describe briefly how to only use parts of the workflow (just in short, the details come in the GTN)
If the tests work it can be merged from my side, then we can make updates in a new PR, for this huge PR the GitHub rendering often fails. |
The test data files should go to zenodo. |
Hey @mvdbeek, |
I have a bunch of pending comments, there are a few changes still necessary. I'll get those submitted when I'm back at my computer |
workflows/amplicon-mgnify/mapseq-to-ampvis2/mapseq-to-ampvis2.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon-mgnify/mapseq-to-ampvis2/mapseq-to-ampvis2-tests.yml
Outdated
Show resolved
Hide resolved
workflows/amplicon-mgnify/mapseq-to-ampvis2/mapseq-to-ampvis2-tests.yml
Outdated
Show resolved
Hide resolved
...amplicon-mgnify/mgnify-amplicon-pipeline-v5-complete/mgnify-amplicon-pipeline-v5-complete.ga
Outdated
Show resolved
Hide resolved
...amplicon-mgnify/mgnify-amplicon-pipeline-v5-complete/mgnify-amplicon-pipeline-v5-complete.ga
Outdated
Show resolved
Hide resolved
"name": "SE Trimmomatic - LEADING" | ||
} | ||
], | ||
"label": "SE Trimmomatic - LEADING", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter is also optional, is that correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of the tool itself you are right, it is optional. Here it is actually set to a default value, because this is the pipeline default value..
"name": "SE Trimmomatic - TRAILING" | ||
} | ||
], | ||
"label": "SE Trimmomatic - TRAILING", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
...amplicon-mgnify/mgnify-amplicon-pipeline-v5-complete/mgnify-amplicon-pipeline-v5-complete.ga
Outdated
Show resolved
Hide resolved
You're missing the release field in the workflows now: |
@mvdbeek is it possible to add the infernal indexes to the CVMFS? I think this is the reason why cmsearch is failing.. |
Sure, I'll copy that from .eu |
WIP!