Fix test syntax issues passing #531
Conversation
lldelisle
force-pushed
the
fix_syntax_passing
branch
from
815c522
to
fc78f57
Compare
|
Same question as #533 , I don't know if these changes require a bump version. |
|
No, if we're only changing the tests I don't think we need to do that. It doesn't affect the workflow itself. |
| @@ -12,22 +12,18 @@ | |||
| Ploidy: 1 | |||
| outputs: | |||
| GenomeScope linear plot: | |||
| class: File | |||
There was a problem hiding this comment.
@jmchilton do we like this ? It's a great union discriminator that would give us cleaner validation reports, I think ?
There was a problem hiding this comment.
The inputs you could argue are files. These are datasets - definitely not files. But the way CWL uses the word File is also just a real problem for my literal brain. We've already given into the syntax so why not just continue I guess. It is hard to appreciate consistency and technical quality of something that is wrong 😆. We can make this required in the best practice schema I think 😿. Will you give me the that syntax on the same argument about having a good clean discriminator 😆?
There was a problem hiding this comment.
Sure, that's fine. I guess we're still at the stage of defining what works, and then next step consolidating into something we like ?
See #530