Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test in workflows/genome-assembly/bacterial-genome-assembly #537

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fixing test in workflows/genome-assembly/bacterial-genome-assembly #537

merged 3 commits into from
Sep 27, 2024
+10 −10

Conversation

clsiguret
Copy link
Contributor

I fixed the test for shovill_contigs_graph identified in #530.
Thanks 😃

bebatut
bebatut previously approved these changes Sep 27, 2024
View reviewed changes
@lldelisle
Copy link
Contributor

A change in the test do not require a version bump. I think you can simply change the test result without any CHANGELOG and version bump because the workflow itself has not changed.

@clsiguret clsiguret changed the title Updating workflows/genome-assembly/bacterial-genome-assembly from 1.1.2 to 1.1.3 Fixing test in workflows/genome-assembly/bacterial-genome-assembly Sep 27, 2024
@lldelisle
Copy link
Contributor

Thank you so much! If you want, I can merge it.
Would you mind to do the same for https://github.com/galaxyproject/iwc/pull/530/files#diff-a0c792148371a997ce12b4dedb4450e8d53faaabfeade06e29af607dc3e7fd25?

@clsiguret
Copy link
Contributor Author

Thank you so much! If you want, I can merge it. Would you mind to do the same for https://github.com/galaxyproject/iwc/pull/530/files#diff-a0c792148371a997ce12b4dedb4450e8d53faaabfeade06e29af607dc3e7fd25?

Thanks a lot!
Yeah, i need to do the same for this workflow 😃 (ongoing)

@lldelisle lldelisle merged commit 528249d into galaxyproject:main Sep 27, 2024
6 checks passed
@clsiguret clsiguret deleted the bacterial-genome-assembly_update branch September 27, 2024 08:42
@clsiguret
Copy link
Contributor Author

Thanks @lldelisle 😃

@mvdbeek
Copy link
Member

mvdbeek commented Sep 27, 2024

Attention: deployment failure!

https://github.com/galaxyproject/iwc/actions/runs/11067415737

@clsiguret
Copy link
Contributor Author

Attention: deployment failure!

https://github.com/galaxyproject/iwc/actions/runs/11067415737

Nooo 😱
So we need to do the 1.1.3 bump ?

@clsiguret clsiguret restored the bacterial-genome-assembly_update branch September 27, 2024 09:02
@clsiguret clsiguret mentioned this pull request Sep 27, 2024
Merged
@lldelisle
Copy link
Contributor

No, we just ignore the failure.

@clsiguret clsiguret deleted the bacterial-genome-assembly_update branch September 27, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lldelisle lldelisle lldelisle approved these changes

@bebatut bebatut Awaiting requested review from bebatut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clsiguret @lldelisle @mvdbeek @bebatut