[WIP] Implement serve flag for planemo test #1185
Conversation
simonbray
force-pushed
the
serve-test
branch
3 times, most recently
from
271426d
to
3ae767c
Compare
planemo/engine/test.py
Outdated
| @@ -15,6 +22,17 @@ | |||
|
|
|||
| def test_runnables(ctx, runnables, original_paths=None, **kwds): | |||
| """Return exit code indicating test or failure.""" | |||
| if kwds.get("serve"): | |||
| kwds["engine"] = "external_galaxy" | |||
There was a problem hiding this comment.
Maybe not this only works with that engine type in the option help?
simonbray
changed the title
simonbray
changed the title
simonbray
force-pushed
the
serve-test
branch
2 times, most recently
from
0be55c4
to
97000c2
Compare
simonbray
force-pushed
the
serve-test
branch
2 times, most recently
from
3e9f99c
to
7705734
Compare
This comment has been minimized.
This comment has been minimized.
|
Thats a nice idea! 👏 If you feel this is ready, do not forget to remove the WIP. |
Thanks!
@gallardoalba agreed to test it out, so I will keep it as WIP until then, but it seems to be working ok as far as I can tell. |
| with temp_directory(dir=ctx.planemo_directory) as temp_path: | ||
| with ExitStack() as stack: | ||
| if not kwds["serve"]: | ||
| temp_path = stack.enter_context(temp_directory(dir=ctx.planemo_directory)) |
There was a problem hiding this comment.
Fascinating! I had no clue about this.
There was a problem hiding this comment.
Yes, new for me as well, I came across it while searching for a way to write a conditional with statement.
| pid = os.fork() | ||
| if pid == 0: | ||
| # wait for served Galaxy instance to start | ||
| sleep(kwds["galaxy_url"], verbose=ctx.verbose, timeout=500) | ||
| # then proceed to test against it | ||
| kwds["engine"] = "external_galaxy" | ||
| else: | ||
| # serve Galaxy instance | ||
| galaxy_serve(ctx, runnables, **kwds) | ||
| exit(1) |
There was a problem hiding this comment.
Forking in the presence of threads seems brittle. With #1232 we're removing the run_tests.sh mode, so you could just sleep infinitely in cmd_test.sh / cmd_shed_test.sh after merging this.
Implement #1175.