Fix type comparisons #1382
Merged
Fix type comparisons #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter complained about this over here galaxyproject#1381
mvdbeek
reviewed
Aug 7, 2023
planemo/workflow_lint.py
Outdated
| @@ -191,12 +191,12 @@ def _lint_best_practices(path: str, lint_context: WorkflowLintContext) -> None: | |||
| """ | |||
|
|
|||
| def check_json_for_untyped_params(j): | |||
| values = j if type(j) == list else j.values() | |||
| values = j if isinstance(j, list) else j.values() | |||
There was a problem hiding this comment.
Can you check this is a dict instance instead ? that should be less narrow. Also the check in line 196 isn't really how you'd do this
There was a problem hiding this comment.
Can you check this is a dict instance instead ?
So is TYPE everywhere?
Also the check in line 196 isn't really how you'd do this
Also with is?
There was a problem hiding this comment.
No, type is type is the most narrow of them all which will not work for any subclasses. .values() will only work for objects that satisfy Mapping, while any j that is Iterable will work. So check for the specific instance where you need to call .values() first isinstance(j, Mapping) and don't worry about the other types that will all be fine.
bernt-matthias
commented
Aug 7, 2023
mvdbeek
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linter complained about this over here #1381
Not sure if
isinstanceorisis correct?