Tool linting add --skip_file and remove lxml schema validation
#1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
linting-news
branch
2 times, most recently
from
f322c97
to
58a45ab
Compare
mvdbeek
reviewed
Jan 15, 2024
bernt-matthias
force-pushed
the
linting-news
branch
from
ce7f22a
to
2ea43a4
Compare
bernt-matthias
commented
Jan 16, 2024
bernt-matthias
force-pushed
the
linting-news
branch
2 times, most recently
from
8b2571b
to
0da0337
Compare
5 tasks
bernt-matthias
force-pushed
the
linting-news
branch
2 times, most recently
from
14519c9
to
702167d
Compare
|
@mvdbeek this one would also be needed. For IUC my plan is to allow a global skip file and per tool skip files. Should I allow to specify I was also thinking if it would be cool to allow changing the level (info, warning, error, ...) for each linter instead of just enabling or disabling it? For now I would go for enable/disable since setting the level would require a change to tool-util again. |
now in galaxy core galaxyproject/galaxy#17081
new option allowing to specify one or more files listing linters to skip
This reverts commit bc4a3f2. The xsd linting is used also to other xml files, tool_dependencies.xml. So I guess the changed default for `--xsd` should be suffiecient
will only work with 24.0
bernt-matthias
force-pushed
the
linting-news
branch
from
702167d
to
7ad8fb2
Compare
mvdbeek
reviewed
May 7, 2024
mvdbeek
reviewed
May 8, 2024
mvdbeek
approved these changes
May 8, 2024
nsoranzo
added a commit
to nsoranzo/planemo
that referenced
this pull request
Jul 16, 2024
Follow-up on galaxyproject#1420 which should have included these version bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref galaxyproject/galaxy#17081