Bump galaxy packages to allow for 24.0 #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mvdbeek
reviewed
May 2, 2024
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
May 3, 2024
until 23.2 we had linter functions lint_xyz in linter modules xyz. with 24.0 we splited the functions linter classes. lint contexts allow to skip linters by name (xyz for the old functions now the class name), i.e. we can not skip by the old names anymore. this may break planemo command lines xref galaxyproject/planemo#1441 (comment). here I suggest to add a check for the module name against the names listed in the skip list. this restores the possibility to skip by old linter names and adds the possibility to skip whole linter modules (which might be handy anyway). tried to add some tests that hopefully help to maintain this functionality.
4 tasks
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
May 3, 2024
until 23.2 we had linter functions lint_xyz in linter modules xyz. with 24.0 we splited the functions linter classes. lint contexts allow to skip linters by name (xyz for the old functions now the class name), i.e. we can not skip by the old names anymore. this may break planemo command lines xref galaxyproject/planemo#1441 (comment). here I suggest to add a check for the module name against the names listed in the skip list. this restores the possibility to skip by old linter names and adds the possibility to skip whole linter modules (which might be handy anyway). tried to add some tests that hopefully help to maintain this functionality.
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
May 3, 2024
until 23.2 we had linter functions lint_xyz in linter modules xyz. with 24.0 we splited the functions linter classes. lint contexts allow to skip linters by name (xyz for the old functions now the class name), i.e. we can not skip by the old names anymore. this may break planemo command lines xref galaxyproject/planemo#1441 (comment). here I suggest to add a check for the module name against the names listed in the skip list. this restores the possibility to skip by old linter names and adds the possibility to skip whole linter modules (which might be handy anyway). tried to add some tests that hopefully help to maintain this functionality.
mvdbeek
reviewed
May 3, 2024
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
This reverts commit d323516.
mvdbeek
reviewed
May 7, 2024
Since they each had linting issues
mvdbeek
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.