Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/jasminesv tool to 1.1.5 1.1.5 #3816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

planemo-autoupdate
Copy link
Contributor

Hello! This is an automated update of the following tool: tools/jasminesv. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

Please see https://github.com/planemo-autoupdate/autoupdate for more information.

@simonbray simonbray force-pushed the tools/jasminesv branch 2 times, most recently from 1658d43 to 542ae69 Compare October 21, 2021 14:12
@@ -0,0 +1,2 @@
10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the tool know which threshold belongs to which sample?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the same order as in vcffilelist, anything else would be very strange.

I guess there is the problem that multiple="true" does not allow dataset ordering though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the 'nicest' option would be a repeat containing both the VCF file and an optional float param for the threshold, assuming the number of VCF files generally used is not too high.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A repeat might be nice for interactive tool use, but seems not of much use for automation, eg in workflows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the best option then? To write a note in the help encouraging users to submit datasets as a collection if they want to use individual thresholds, so that ordering is guaranteed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

  • collection + tsv using identifiers for automatized use cases
  • repeat for interactive use

<option value="" selected="true">Don't specify distance thresholds</option>
</param>
<when value="sample_dists">
<param name="sample_dists_file" type="data" format="txt,tsv" value="" label="A file containing distance thresholds for each sample, one per line"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just tsv .. or even better tabular?

@planemo-autoupdate planemo-autoupdate changed the title Updating tools/jasminesv tool version(s) Updating tools/jasminesv tool to 1.1.5 May 9, 2022
@gxydevbot gxydevbot changed the title Updating tools/jasminesv tool to 1.1.5 Updating tools/jasminesv tool to 1.1.5 1.1.5 Sep 26, 2024
@gxydevbot
Copy link
Collaborator

There are new updates, they have been integrated to the PR, check the file diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants