Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter fixes for poretools #6362

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Linter fixes for poretools #6362

merged 8 commits into from
Sep 27, 2024

Conversation

bernt-matthias
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

bgruening
bgruening reviewed Sep 26, 2024
View reviewed changes
tools/poretools/poretools_events.xml Outdated
@@ -1,10 +1,9 @@
<?xml version="1.0"?>
<tool id="poretools_events" name="Extract nanopore events" version="@VERSION@.1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add profiles to all tools?

@bgruening
Copy link
Member

Do we stop the CI on merge?

@bernt-matthias
Copy link
Contributor Author

Do we stop the CI on merge?

No, too many reasons to deploy:

  • changed (fixed) parameters
  • changed profile

@bgruening bgruening merged commit 506782d into galaxyproject:main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernt-matthias @bgruening