-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tools/jasminesv tool to 1.1.5 1.1.5 1.1.5 #3816
base: main
Are you sure you want to change the base?
Updating tools/jasminesv tool to 1.1.5 1.1.5 1.1.5 #3816
Conversation
1658d43
to
542ae69
Compare
@@ -0,0 +1,2 @@ | |||
10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the tool know which threshold belongs to which sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the same order as in vcffilelist
, anything else would be very strange.
I guess there is the problem that multiple="true"
does not allow dataset ordering though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the 'nicest' option would be a repeat containing both the VCF file and an optional float param for the threshold, assuming the number of VCF files generally used is not too high.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A repeat might be nice for interactive tool use, but seems not of much use for automation, eg in workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the best option then? To write a note in the help
encouraging users to submit datasets as a collection if they want to use individual thresholds, so that ordering is guaranteed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so
- collection + tsv using identifiers for automatized use cases
- repeat for interactive use
tools/jasminesv/jasminesv.xml
Outdated
<option value="" selected="true">Don't specify distance thresholds</option> | ||
</param> | ||
<when value="sample_dists"> | ||
<param name="sample_dists_file" type="data" format="txt,tsv" value="" label="A file containing distance thresholds for each sample, one per line"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just tsv
.. or even better tabular
?
There are new updates, they have been integrated to the PR, check the file diff. |
1dcca7f
to
dec68f1
Compare
dec68f1
to
af351a0
Compare
There are new updates, they have been integrated to the PR, check the file diff. |
Hello! This is an automated update of the following tool: tools/jasminesv. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.
Please see https://github.com/planemo-autoupdate/autoupdate for more information.