-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update STAR version + new options for STARsolo #5060
Merged
bernt-matthias
merged 36 commits into
galaxyproject:main
from
lldelisle:starsolo_update
Feb 17, 2023
Merged
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b52f63b
update STAR version
lldelisle 1006e84
add GeneQuant + outSAMattributes
lldelisle f450b3e
remove dup test
lldelisle a7cb191
update tool version [no ci]
lldelisle 2b72bb8
lint
lldelisle 8f42952
add SAMattributes in macro as suggested by @wm75
lldelisle c3b1dc3
change Cell Ranger to Chromium chemistry
lldelisle 45afe99
Update rg_rnaStarSolo.xml
pavanvidem e91e9f3
Update macros.xml
pavanvidem 662ba6d
Update rg_rnaStar.xml
pavanvidem 033cd4a
STAR: allow fasta.gz for reference
bernt-matthias 3ca8610
Merge pull request #2 from pavanvidem/patch-4
lldelisle d374110
use up to date profile
lldelisle 5fe1484
fix back to line
lldelisle ca87f87
increase GenomeGenerateRAM by @nagoue @bgruening @wm75
lldelisle b69a4b2
fix macro limits + extend to all starSOLO
lldelisle a34c128
use double getVar
lldelisle 0103d32
compare params values with command line
lldelisle 0d80c76
put default value in second getVar
lldelisle dba503d
add colnames to count file
lldelisle 3ed614c
add outWig to STAR
lldelisle 9c5210c
add outWig in STARsolo + compress bam
lldelisle 443ebd2
remove section coverage
lldelisle ae0f3c7
add ftype in test
lldelisle 065d90e
fix output matrix for new soloFeatures + add test
lldelisle b5142ff
Merge pull request #4 from lldelisle/outWig
lldelisle 117ce39
solve #1777
lldelisle 95831a6
put quantmode_output in GTFconditional thanks @bernt-matthias
lldelisle 1ff30c2
Merge pull request #3 from lldelisle/solve1777
lldelisle 19b6882
change default outSAMmapqUnique to 255 like in STAR
lldelisle 20a2126
only use soloUMIfiltering when soloUMIdedup is 1MM_CR
lldelisle dfe88ea
enable to output filtered and raw matrices
lldelisle c6c4822
add forgotten requirement
lldelisle 296660c
use @TOOL_VERSION@+galaxy@VERSION_SUFFIX@
lldelisle 53faaa4
bump version of data_manager
lldelisle e3966b9
put back to MAPQ60 with remark
lldelisle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools-iuc/data_managers/data_manager_star_index_builder/data_manager/rna_star_index_builder.xml
Line 1 in 02d1d48
is what this comment refers to.
This PR should, because of the linked macros file, trigger deployment of a new version of the DM, too, so you need to bump the DM version to
version="@IDX_VERSION@+galaxy1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we should change the version because we changed STAR version or because of something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess bumping the
IDX_VERSION_SUFFIX
does not hurt, but I do not understand why we should do it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to indicate that we use the STAR version @TOOL_VERSION@ instead of the STAR version @IDX_VERSION@ to build the index...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernt-matthias @lldelisle Just to explain things: the reason for symlinking the macros file is to keep the IDX_VERSION in one place only so that when you update the tool wrapper to a STAR version that requires a newer index format, you'd automatically deploy also a DM that can create these indexes.
The "downside" is that any changes to the tool wrapper macros file will silently affect the DM. So in this case the next version of the DM will use the 2.7.10b version of star for building indexes. These should be identical to ones built with older versions, but it's good to bump the DM wrapper version to be able to trace things back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit.
Could a more expressive filter help here. For instance we could just store the star version that was used to create an entry in the datatable ... and then just filter datatable entries for a min (or max) required star version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is easy to add a new column in a table, this suppose to change the table (which happened when we add a new column for the 'genomeVersion')...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would require a new table. I'm also not so sure whether that would improve the situation much.
min and max version checks in tool wrappers also need quite some discipline to maintain, and the max check in particular doesn't work backwards, i.e., at the time of writing a tool wrapper version the max value is typically unknown still so there's always at least one wrapper version that will display all newer index versions.
What would be comparably easy to do is to remove the symlink and have the DM use its own macro, which then needs to be maintained separately, but would maybe come with fewer surprises.
Anyway, I don't think this should hold back this PR any longer. If we want to decouple the DM from the tool wrapper, we should do it in its own PR where the decision will be more discoverable than as part of a giant PR like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.