Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter exceptions for all linters that are currently failing #6184

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jul 27, 2024

And re-enable warn as linter fail level.

It's like a TODO list :)

      1 HelpMissing
      1 InputsDataFormat
      1 InputsDataOptionsFiltersType
      1 InputsSelectDynamicOptions
      1 InputsSelectOptionsDeprecatedAttr
      1 RequirementVersionMissing
      1 ValidatorExpression
      1 ValidatorExpressionFuture
      2 InputsDataOptionsFilterAttribFiltersType
      2 InputsDataOptionsFiltersRef
      2 InputsNameDuplicateOutput
      2 InputsSelectOptionDuplicateValue
      2 OutputsNameDuplicated
      2 OutputsNameInvalidCheetah
      2 TestsOutputCompareAttrib
      2 ToolIDWhitespace
      2 XSD
      3 CommandTODO
      3 EDAMTermsValid
      3 InputsMissing
      3 TestsExpectNumOutputsFailing
      4 ConditionalWhenMissing
      4 InputsBoolDistinctValues
      4 InputsNameDuplicate
      4 InputsSelectOptionDuplicateText
      5 HelpInvalidRST
      6 HelpEmpty
      9 OutputsLabelDuplicatedNoFilter
     13 ConditionalParamTypeBool
     14 TestsMissing
     15 ToolVersionPEP404
     18 OutputsLabelDuplicatedFilter
     19 TestsParamInInputs
     29 CitationsNoValid
     32 CitationsMissing
     41 InputsNameRedundantArgument
     73 TestsExpectNumOutputs
    103 XMLOrder

Should replace #5650

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Jul 29, 2024

The remaining tool linter errors are all due to linters defined in planemo (working in it: galaxyproject/planemo#1472)

Tool tests won't finish with 4 chunks (and likely there fill be failing tests anyway).

I will fix the python linter problems.

@bgruening
Copy link
Member

Do you want me to fix a few other stuff here or should we merge that and fix other stuff later?

If we merge this PR, so we cancel the CI or do we deploy?

@bernt-matthias
Copy link
Contributor Author

If we merge this PR, so we cancel the CI or do we deploy?

I would not deploy. Since we do not change any tools (I should undo the changes to py and xml files and but them in a separate PR)

Do you want me to fix a few other stuff here or should we merge that and fix other stuff later?

I would put any other changes to a separate PRs.

@bernt-matthias
Copy link
Contributor Author

The XSD errors are maybe due to a bug: galaxyproject/galaxy#18605

@bernt-matthias bernt-matthias force-pushed the topic/skip_lint branch 2 times, most recently from efdb156 to 5c67e5d Compare July 29, 2024 10:30
@bgruening bgruening force-pushed the topic/skip_lint branch 2 times, most recently from 8ab83ba to 86a7364 Compare August 25, 2024 15:24
@bgruening
Copy link
Member

@bernt-matthias please also have a look at bernt-matthias#107 ... not sure where it should go. Please let me know how you want to have those fixes.

@bgruening
Copy link
Member

All the remaining failures are URLs that are not valid anymore.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@mvdbeek mvdbeek merged commit d7032f8 into galaxyproject:main Sep 5, 2024
18 of 28 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Sep 5, 2024

Attention: deployment skipped!

https://github.com/galaxyproject/tools-iuc/actions/runs/10719699458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants