Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get workflow id and test from WorkflowHub for tutorial using workflow from WorkflowHub #5060

Open
bebatut opened this issue Jun 19, 2024 · 1 comment

Comments

@bebatut
Copy link
Member

bebatut commented Jun 19, 2024

It would be great for a tutorial using a workflow available on IWC/WorkflowHub to avoid adding the workflow to the tutorial but give its ID and that the workflow on WorkflowHub is displayed for the metadata on the top and that the tests from IWC are used

@hexylena
Copy link
Member

As long as the WF is referenced in the tutorial (through one of the existing snippets) that will be easy to detect and won't require any additional author supplied metadata

while we are in parallel going to upload workflows to WFH ourselves this definitely makes sense to do, but yes will require some new code to

  • detect that they're using those workflows
  • on build, download a copy of the workflow
  • so we can inspect which tools it uses (which might inflate download stats for better or worse) and use our existing mechanisms to compare against servers
  • and then exceptions in relevant places so we don't try and link to an ephemerally downloaded file.

overall shouldn't be too bad to implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants