Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further RTL linting #5076

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Further RTL linting #5076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4918f64
Lint RTL
hexylena Jun 25, 2024
df86b56
lint RTL further
hexylena Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 36 additions & 35 deletions assets/css/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,11 @@ body {
vertical-align: 1em;
float: inline-start;
border: 1px solid $bg-color;
border-top-left-radius: 8px;
border-top-right-radius: 8px;
border-start-start-radius: 8px;
border-start-end-radius: 8px;

.fa {
padding-right: calc($tutorial-box-spacing / 5);
padding-inline-end: calc($tutorial-box-spacing / 5);
}

button {
Expand All @@ -247,26 +247,26 @@ body {
@mixin matrix-table (){
table {
width:unset;
margin-left:auto;
margin-right:auto;
margin-inline-start:auto;
margin-inline-end:auto;
margin-top: 20pt;
}

table thead th {
border-bottom: 2px solid #777;
text-align: left;
text-align: inline-start;
}

table td:first-child, table th:first-child {
border-right: 2px solid #777;
border-inline-end: 2px solid #777;
font-weight: bold;
text-align: left;
text-align: inline-start;
}

table td:not(first-child), table th:not(first-child) {
text-align: center;
border-right: 1px solid #ddd;
border-left: 1px solid #ddd;
border-inline-end: 1px solid #ddd;
border-inline-start: 1px solid #ddd;
}
}

Expand Down Expand Up @@ -431,16 +431,16 @@ div.language-diff .p {
border-top: 1px solid #66d9ef;
border-bottom: 1px solid #66d9ef;

border-left: 5px solid #66d9ef;
border-right: 5px solid #66d9ef;
border-inline-start: 5px solid #66d9ef;
border-inline-end: 5px solid #66d9ef;

font-weight: 900;

line-height: 3em;

margin-right: 1em;
padding-left: 1em;
padding-right: 1em;
margin-inline-end: 1em;
padding-inline-start: 1em;
padding-inline-end: 1em;
}

body > footer {
Expand Down Expand Up @@ -485,7 +485,7 @@ nav.navbar {
}

a.navbar-brand {
padding-right: 2.5em; // the image seems to work poorly with parent size calculations.
padding-inline-end: 2.5em; // the image seems to work poorly with parent size calculations.
}

// Text decoration not necessary for accessibility here.
Expand Down Expand Up @@ -532,7 +532,7 @@ nav input.nicer {
}
}
#search-input {
margin-right:1em;
margin-inline-end:1em;
}

/*
Expand Down Expand Up @@ -718,8 +718,8 @@ blockquote {
border: 1px solid var(--border-light);
.card-title {
color: var(--brand-color-contrast);
// margin-left: -15px; // BS has a 15px margin on cards, this makes the card title fill the card.
// margin-right: -15px;
// margin-inline-start: -15px; // BS has a 15px margin on cards, this makes the card title fill the card.
// margin-inline-end: -15px;
}
}

Expand All @@ -738,8 +738,8 @@ blockquote {
// We have to manually exclude the card titles
// And also canvases because they apparently calculate their area before the CSS has finished.
& > :not(.card-title,canvas){
margin-left: 1em;
margin-right: 1em;
margin-inline-start: 1em;
margin-inline-start: 1em;
}
}
}
Expand Down Expand Up @@ -944,8 +944,8 @@ blockquote {
@media (max-width: 575px) {
.navbar > .container {
position: initial;
margin-left: initial;
margin-right: initial;
margin-inline-start: initial;
margin-inline-end: initial;
}
}

Expand Down Expand Up @@ -1034,7 +1034,7 @@ blockquote {

.level {
color: lightgray;
margin-right: 0.5em;
margin-inline-end: 0.5em;

.fa {
font-size: 0.9em;
Expand Down Expand Up @@ -1167,8 +1167,8 @@ nav[data-toggle='toc'] {
i {
height: 1.5em;
line-height: 1.5em;
margin-left: 0.5em;
margin-right: 0.5em;
margin-inline-start: 0.5em;
margin-inline-end: 0.5em;
}
}

Expand All @@ -1182,7 +1182,7 @@ nav[data-toggle='toc'] {
align-items: center;
border-radius: 1em;
border: 1px dotted var(--hyperlink);
padding-right: 0.5em;
padding-inline-end: 0.5em;
margin: 0.2em;
line-height: 1em;
flex-shrink: 0;
Expand Down Expand Up @@ -1263,14 +1263,15 @@ table.contributions{
div.highlight {
position: relative;
}
/* Code copy button */
div.highlight .btn{
-webkit-transition:opacity .3s ease-in-out;
-o-transition:opacity .3s ease-in-out;
transition:opacity .3s ease-in-out;
opacity:0;
padding:2px 6px;
position:absolute;
right:4px;
inset-inline-end:4px;
top:4px;
}

Expand All @@ -1293,7 +1294,7 @@ div.highlight:hover .btn,div.highlight .btn:focus{
}
.search_box {
float: inline-end;
i {padding-right: .5rem;}
i {padding-inline-end: .5rem;}
}
#clear_search{
cursor: pointer;
Expand Down Expand Up @@ -1434,7 +1435,7 @@ video::cue {
overflow-y: scroll;

tr td:nth-child(1) {
padding-right: 1em;
padding-inline-end: 1em;
color: var(--text-color-muted);
}
}
Expand Down Expand Up @@ -1476,7 +1477,7 @@ div.contributors-line {
}
dt {
width: 8em;
text-align: right;
text-align: end;
font-weight: initial;
}
dd {
Expand Down Expand Up @@ -1786,7 +1787,7 @@ figure > a[target="_blank"]::after {
}

figcaption {
text-align: left;
text-align: start;
}
}

Expand Down Expand Up @@ -1862,8 +1863,8 @@ section.event {
cursor: pointer;
background: none;
font-size: 1.2rem;
border-top-left-radius: 0;
border-top-right-radius: 0;
border-start-start-radius: 0;
border-start-end-radius: 0;

&:hover {
color: var(--hyperlink-hover);
Expand Down Expand Up @@ -1929,7 +1930,7 @@ body[data-brightness="dark"] {
width: 25%;
}
table tr td:nth-child(2) {
text-align: left;
text-align: start;
display: table-cell;
width: 100%;
}
Expand Down
77 changes: 77 additions & 0 deletions bin/lint.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,72 @@ def self.fix_ga_wf(contents)
results
end

def self.fix_css(contents)
results = []
results += find_matching_texts(contents, /margin-left/)
.map do |idx, _text, selected|
ReviewDogEmitter.warning(
path: @path,
idx: idx,
match_start: selected.begin(1),
match_end: selected.end(1) + 1,
replacement: 'margin-inline-start',
message: 'Use margin-inline-start to support right-to-left languages See: https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html',
code: 'GTN:037'
)
end
results += find_matching_texts(contents, /margin-right/)
.map do |idx, _text, selected|
ReviewDogEmitter.warning(
path: @path,
idx: idx,
match_start: selected.begin(1),
match_end: selected.end(1) + 1,
replacement: 'margin-inline-end',
message: 'Use margin-inline-end to support right-to-left languages See: https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html',
code: 'GTN:037'
)
end
results += find_matching_texts(contents, /padding-left/)
.map do |idx, _text, selected|
ReviewDogEmitter.warning(
path: @path,
idx: idx,
match_start: selected.begin(1),
match_end: selected.end(1) + 1,
replacement: 'padding-inline-start',
message: 'Use padding-inline-start to support right-to-left languages See: https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html',
code: 'GTN:037'
)
end
results += find_matching_texts(contents, /padding-right/)
.map do |idx, _text, selected|
ReviewDogEmitter.warning(
path: @path,
idx: idx,
match_start: selected.begin(1),
match_end: selected.end(1) + 1,
replacement: 'padding-inline-end',
message: 'Use padding-inline-end to support right-to-left languages See: https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html',
code: 'GTN:037'
)
end
results += find_matching_texts(contents, /(left|[^b]right)/)
.map do |idx, _text, selected|
ReviewDogEmitter.warning(
path: @path,
idx: idx,
match_start: selected.begin(1),
match_end: selected.end(1) + 1,
replacement: '',
message: 'Use start/end to support right-to-left languages See: https://firefox-source-docs.mozilla.org/code-quality/coding-style/rtl_guidelines.html',
code: 'GTN:037'
)
end

results
end

def self.fix_bib(contents, bib)
bad_keys = bib_missing_mandatory_fields(bib)
results = []
Expand Down Expand Up @@ -1073,6 +1139,14 @@ def self.fix_file(path)
bib = BibTeX.open(path)
results = fix_bib(contents, bib)

results = filter_results(results, ignores)
emit_results(results)
when /.s?css$/
handle = File.open(path, 'r')
contents = handle.read.split("\n")

results = fix_css(contents)

results = filter_results(results, ignores)
emit_results(results)
when /.ga$/
Expand Down Expand Up @@ -1229,6 +1303,9 @@ def self.run_linter_global
)
end
end
enumerate_type(/\.s?css$/).each do |path|
fix_file(path)
end
enumerate_type(/\.ga$/).each do |path|
fix_file(path)
end
Expand Down
Loading