Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #91 I was unable to upload or download anything with an encrypted interface. This code should at least allow the test code below to run.
Given encryption has been broken I'm not sure if anyone has actually used it recently. This might break compatibility with existing encrypted objects, so I would appreciate if someone could test if you could read existing objects.
Note that these changes are only for Python <= 3.7, since PyCrypto depends on
time.clock
, which was removed in Python 3.8. Both this PR and #91 are necessary for supporting >= 3.8.Test code
I also did not see any automated tests for this, so here's a short snippet that should work:
I can enable all existing tests to also run for encrypted interfaces, but this doubles testing time so I haven't included it here (but I can if that's not an issue).