Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAL-3939 WIP start updating collection page scroll behavior #1971

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kaitoo1
Copy link
Collaborator

@kaitoo1 kaitoo1 commented Sep 28, 2023

Summary of Changes

Update scroll behavior of collection page so that we collapse certain header elements.

Pending resolution of scroll position issue: PedroBern/react-native-collapsible-tab-view#372

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots. You can type /table to quickly come up with a before/after table.

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 7:45am

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Bundle Sizes

Compared against 3f8f4c0

Route: No significant changes found

Dynamic import: No significant changes found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant