Fix Versions page closes #410, credits to EliasVal <3 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original author: https://github.com/EliasVal See game-ci#412
|
|
webbertakken
approved these changes
Oct 24, 2023
|
Did you wanna cherry-pick the changes to preserve the original author? |
Oups, indeed, should have done that, but I missed your notification. My bad. Credits definitely goes to https://github.com/EliasVal here. At least commit history shows it, 510afa3 message as well, but you're right, I should have done a cherry-pick in the first place. I did it this way testing locally: git checkout 62090d3 src/components/docs/versions/
git checkout 62090d3 src/components/molecules/tooltip/Then I did commit. I'll make sure to do it properly next time. Again, huge thanks to @EliasVal and sorry about history and stats. Hopefully, it's still there in history before the revert. The version page is way better now ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original author: https://github.com/EliasVal
See #412
Changes
Todo