Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scoped registries #453

Merged
merged 5 commits into from
Mar 22, 2024
Merged

feat: scoped registries #453

merged 5 commits into from
Mar 22, 2024

Conversation

nvandessel
Copy link
Contributor

@nvandessel nvandessel commented Feb 28, 2024

Changes

  • Add documentation relevant to the use of scopedRegistryUrl and registryScopes
  • Add documentation for private scoped registries and using the UPM_REGISTRY_TOKEN environment variable

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@nvandessel nvandessel marked this pull request as ready for review February 29, 2024 00:38
Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be merged only when related PR is merged 👍 Nice work.

Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>
@nvandessel
Copy link
Contributor Author

Thank you so much! Appreciate the keen eye finding that typo! 😬

@GabLeRoux
Copy link
Member

Let's merge this. Only missing thing to do is to fix code formatting with yarn lint. 👍

@GabLeRoux
Copy link
Member

I wasn't able to update your branch, but I was able to create a new branch in this repository here: https://github.com/game-ci/documentation/tree/feature/scoped-registries

@nvandessel
Copy link
Contributor Author

nvandessel commented Mar 15, 2024

@GabLeRoux I'm fine with closing this one and opening another from the other branch if that's easiest!

I also just went and ran the yarn lint from gh codespaces, so if it's preferable to merge this PR seeing as it's linked in the others then that works too. Whatever works and is best for you!

@GabLeRoux GabLeRoux enabled auto-merge (squash) March 22, 2024 15:38
@GabLeRoux GabLeRoux merged commit 57c4c9c into game-ci:main Mar 22, 2024
5 checks passed
@nvandessel nvandessel deleted the feature/scoped-registries branch March 22, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants