Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Reporting #52

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix Build Reporting #52

merged 2 commits into from
Jun 6, 2024

Conversation

AndrewKahr
Copy link
Member

Changes

  • Make discord a global instance to reduce the amount of connects called

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the discord limits versus amount of invocations of the versioning backend.

This is a challenge inherent to running it the backend as cloud functions triggered as a cron and triggering based on db changes as well as rest calls; we need to minimise the number of connections to discord and always make sure we disconnect. That's why it used to be a singleton.

Sorry I didn't catch it as part of the review of your previous PR.

Nice fix.

@AndrewKahr AndrewKahr merged commit e3d917f into main Jun 6, 2024
4 checks passed
@AndrewKahr AndrewKahr deleted the fix-build-reporting branch June 6, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants