Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countersunk bolts and warning about use of Loctite on plastic #431

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

Ridleyyy
Copy link
Contributor

Added countersunk head bolts to the fastener guide including image.
Added warning about use of Loctite on plastic such as polycarbonate, included links to alternatives.

@abidingabi
Copy link
Member

Hello, I would like to make sure that this is intentionally marked as a draft? If it is intended for review, please mark it as such. Thanks!

Note, your other pull request is also marked as a draft.

@abidingabi abidingabi added Hardware Has to do with hardware Type: Enhancement Add information that isn't already present in an article labels Jul 16, 2024
@Ridleyyy
Copy link
Contributor Author

Hello, I would like to make sure that this is intentionally marked as a draft? If it is intended for review, please mark it as such. Thanks!

Note, your other pull request is also marked as a draft.

Sorry I checked the gm0 page on contribution and it noted to use draft pull requests but now I understand this is focused on while you are still developing the page. Updated now.

@Ridleyyy Ridleyyy marked this pull request as ready for review July 17, 2024 00:56
Copy link
Member

@abidingabi abidingabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this helps disambiguate a little bit and also makes it so we do not have two danger admonitions in a row.

source/docs/hardware-components/fastener-guide.rst Outdated Show resolved Hide resolved
source/docs/hardware-components/fastener-guide.rst Outdated Show resolved Hide resolved
@abidingabi abidingabi merged commit 78d5d7a into gamemanual0:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Has to do with hardware Type: Enhancement Add information that isn't already present in an article
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants