Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix compilation errors related to PARTICLE condition #367

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[Bugfix] Fix compilation errors related to PARTICLE condition #367

merged 3 commits into from
Oct 23, 2024

Conversation

hfhsieh
Copy link
Contributor

@hfhsieh hfhsieh commented Oct 23, 2024 •
edited
Loading

  • Fix the compilation problem (linker) when disabling GRAVITY but enabling PARTICLE
  • Fix the compilation error (OPT__OUTPUT_PAR_MESH) when disabling PARTICLE
  • Fix the potential runtime error when enabling PARTICLE and disabling TRACER

@hyschive hyschive added the bugfix Fix bugs label Oct 23, 2024
hyschive
hyschive approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hfhsieh Thanks for the bugfix!

@hyschive hyschive merged commit d3cdc92 into gamer-project:main Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyschive hyschive hyschive approved these changes

Assignees
No one assigned
Labels
bugfix Fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfhsieh @hyschive