Added defines and QSlider Tooltips #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added enums for all the tabs and subtabs so that we can use constants instead of numerical literals. I've also created a new type of slider that displays the current value in the tooltip and updated all sliders with this.
|
please try to rebase on current master |
|
Developement is active on master branch maybe you can try to rebase on it |
|
Please update |
|
This PR looks super interesting; I'd love to see that merged onto master 👍 |
|
please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added enums for all the tabs and subtabs so that the tabs can be referenced by constants instead of numerical literals. Since most of the tabs aren't referenced directly, several of the enums may be superfluous. I've also created a new type of slider that displays the current value in the tooltip and updated all sliders to be this type to give a way to view the exact value.