show serial interfaces in current macOS versions #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Sierra and highSierra the serial ports in macOS have been named cu.something and tty.something. So for each port there are two variants. This also applies to bluetooth ports Could this be changed in the code so serial ports gets shown in macOS again?
rzr
reviewed
Sep 30, 2018
| @@ -175,8 +175,8 @@ void XprotolabInterface::checkForAvailableComPorts(){ | |||
| bool XprotolabInterface::checkIfCorrectPort(QString name){ | |||
| #ifdef Q_OS_WIN | |||
| return name.toLower().startsWith("com"); | |||
| #elif defined(Q_OS_MAC) | |||
| return name.toLower().startsWith("bluetooth"); | |||
| // #elif defined(Q_OS_MAC) | |||
There was a problem hiding this comment.
better surround with #if false && ...
|
Please update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Sierra and highSierra the serial ports in macOS have been named
cu.something and tty.something. So for each port there are two
variants. This also applies to bluetooth ports
Could this be changed in the code so serial ports gets shown in macOS
again?