TikZ splash now uses png; demos and documentation added #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 26.14% 26.00% -0.14%
==========================================
Files 14 14
Lines 876 892 +16
==========================================
+ Hits 229 232 +3
- Misses 647 660 +13
|
|
Added also some warnings if any of the intermediate steps to create the png (pdflatex+pdftoppm+pdfinfo+base64) fails. |
pedritomelenas
commented
Aug 31, 2024
| @@ -1,10 +1,5 @@ | |||
| InstallMethod( JupyterRender, [ IsRecord ], | |||
There was a problem hiding this comment.
This was moved to JupyterRenderable.gi
It makes more sense to be there
pedritomelenas
commented
Aug 31, 2024
| @@ -1,5 +1,9 @@ | |||
| #! @Chapter Jupyter Utility Functions | |||
| #! @Section Functions | |||
There was a problem hiding this comment.
more descritptive title for the section
pedritomelenas
commented
Aug 31, 2024
| # This is still an ugly hack, but its already much better than before! | ||
| BindGlobal("JupyterSplashDot", |
There was a problem hiding this comment.
Used InstallGlobalFunction + declare to add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TikZ now uses png (via pdftoppm). In this way it outputs correctly both on linux and macos. Also, github notebook previewer shows the graphics properly.
Documentation for
JupyterSplashDotandJupyterSplashTikZadded.Demo notebooks for dot (with numericalsgps) and tikz (with intpic) added.