ExtendedImageSet is now a HashSet + all the consequences

ChangeLog

@@ -1,3 +1,5 @@
+0.9.7
+	Breaking changes: ContainsSet(sk, P) replaced with P in ExtendedImageSet(sk), since ExtendedImageSet is now a HashSet for faster lookup. SortedExtendedImageSet added for retaining the functionality of having a sorted list of the extended images.
 0.9.6
 	MakeRepresentative added. To simplify the process of changing a representative, the primitve caching mechanism for the words navigating in the equivalence classes were removed. This makes computing the morphism for holonomy less performant. Proper memoization is to be added later.
 0.9.5

doc/holonomy.xml

@@ -13,6 +13,8 @@ can create, display and act on finite sets.
 The skeleton of a transformation semigroup is a data structure containing information about the action on the state set. For instance, the set of images, their strongly connected components and mapping between and within these components. These details are calculated by the <Package>Semigrops</Package> package.
 <#Include Label="Skeleton">
 <#Include Label="ExtendedImageSet">
+<#Include Label="SortedExtendedImageSet">
+
 <#Include Label="Singletons">
 <#Include Label="NonImageSingletons">
 <#Include Label="RepresentativeSets">

doc/mansections.xml

@@ -524,17 +524,18 @@ Transformation( [ 1, 3, 1, 2 ] )
 <#GAPDoc Label="ExtendedImageSet">
   <ManSection>
     <Attr Name="ExtendedImageSet" Arg="skeleton"/>
-    <Returns>The set of images of the semigroup action.</Returns>
+    <Returns>The extended set of images of the semigroup action.</Returns>
     <Description>
 The state set, the singletons and all image sets <M>X^s, s\in S</M>.
+Stored in a HashSet, thus it is useful for quick checks for the existence of an image.
 <Example>
-gap> SgpDecFiniteSetDisplayOn();
 gap> S := Semigroup(Transformation([1,1,3,3]));
 &lt;commutative transformation semigroup of degree 4 with 1 generator&gt;
 gap> sk := Skeleton(S);;
-gap> ExtendedImageSet(sk);
-[ {1,2,3,4}, {1,3}, {1}, {2}, {3}, {4} ]
-gap> SgpDecFiniteSetDisplayOff();
+gap> FiniteSet([1,3],4) in ExtendedImageSet(sk);
+true
+gap> FiniteSet([2,3],4) in ExtendedImageSet(sk);
+false
 </Example>
     </Description>
   </ManSection>
@@ -1032,6 +1033,26 @@ gap> Skeleton(FullTransformationSemigroup(4));
   </ManSection>
 <#/GAPDoc>
 
+<#GAPDoc Label="SortedExtendedImageSet">
+  <ManSection>
+    <Func Name="SortedExtendedImageSet" Arg="skeleton"/>
+    <Returns>The extended set of images of the semigroup action sorted in descending order.</Returns>
+    <Description>
+The state set, the singletons and all image sets <M>X^s, s\in S</M>.
+<Example>
+gap> SgpDecFiniteSetDisplayOn();
+gap> S := Semigroup(Transformation([1,1,3,3]));
+&lt;commutative transformation semigroup of degree 4 with 1 generator&gt;
+gap> sk := Skeleton(S);;
+gap> SortedExtendedImageSet(sk);
+[ {1,2,3,4}, {1,3}, {1}, {2}, {3}, {4} ]
+gap> SgpDecFiniteSetDisplayOff();
+</Example>
+    </Description>
+  </ManSection>
+<#/GAPDoc>
+
+
 ##T
 
 <#GAPDoc Label="Chains">

lib/finiteset.gd

@@ -2,7 +2,7 @@
 ##
 ## finiteset.gd           SgpDec package
 ##
-## Copyright (C) 2010-2013
+## Copyright (C) 2010-2023
 ##
 ## Attila Egri-Nagy, Chrystopher L. Nehaniv, James D. Mitchell
 ##
@@ -24,6 +24,7 @@ DeclareGlobalFunction("SgpDecFiniteSetDisplayOff");
 DeclareGlobalFunction("FiniteSet");
 DeclareSynonym("Cardinality",SizeBlist);
 DeclareSynonym("FiniteSetSize",SizeBlist);
+DeclareGlobalFunction("FiniteSetComparator");
 DeclareGlobalFunction("OnFiniteSet");
 DeclareGlobalFunction("IsIdentityOnFiniteSet");
 DeclareGlobalFunction("IsSingleton");

lib/finiteset.gi

@@ -2,7 +2,7 @@
 ##
 ## finiteset.gi           SgpDec package
 ##
-## Copyright (C) 2010-2013
+## Copyright (C) 2010-2023
 ##
 ## Attila Egri-Nagy, Chrystopher L. Nehaniv, James D. Mitchell
 ##
@@ -62,6 +62,16 @@ local i;
   return true;
 end);
 
+#for sorting finitesets, first by size, then by content
+InstallGlobalFunction(FiniteSetComparator,
+function(A,B)
+  if SizeBlist(A) <> SizeBlist(B) then
+    return SizeBlist(A)>SizeBlist(B);
+  else
+    return A<B;
+  fi;
+end);
+
 ################################################################################
 ### ToggleFiniSetDisplay #######################################################
 InstallGlobalFunction(SgpDecFiniteSetDisplayOn,

lib/lowerbound.gi

@@ -38,7 +38,7 @@ InstallGlobalFunction(CheckEssentialDependency, function(sk, d1, d2)
 
           skJ := Skeleton(Semigroup(CalI2));
 
-          if ContainsSet( skJ, x2 ) then
+          if x2 in ExtendedImageSet(skJ) then
             JGroup := PermutatorGroup(skJ, x2);
 
             if Size(JGroup) > 1 then # the stricter test is PermutatorGroup(sk, x2) = JGroup

lib/skeleton.gd

@@ -38,7 +38,7 @@ DeclareAttribute("RepresentativeSets",IsSkeleton);
 DeclareGlobalFunction("RepresentativeSetsOnDepth");
 
 #functions
-DeclareGlobalFunction("ContainsSet");
+DeclareGlobalFunction("SortedExtendedImageSet");
 DeclareGlobalFunction("TilesOf");
 DeclareGlobalFunction("TilesContaining");
 DeclareGlobalFunction("DepthOfSet");

lib/skeleton.gi

@@ -61,37 +61,25 @@ function(sk)
   return Filtered(Singletons(sk), x-> not x in ForwardOrbit(sk));
 end);
 
-#for sorting finitesets, first by size, then by content
-DescendingSizeSorter := function(v,w)
-  if SizeBlist(v) <> SizeBlist(w) then
-    return SizeBlist(v)>SizeBlist(w);
-  else
-    return v<w;
-  fi;
-end;
-MakeReadOnlyGlobal("DescendingSizeSorter");
-
 # the image set extended with singletons and ordered by descending size
 # we only need to add non-image singletons, as the base set is in the orbit
 InstallMethod(ExtendedImageSet, "for a skeleton (SgpDec)", [IsSkeleton],
 function(sk)
-  local imageset;
-  #we have to copy it
-  imageset := ShallowCopy(UnderlyingPlist(ForwardOrbit(sk)));
+  local extimgs;
+  extimgs := HashSet();
+  Perform(ForwardOrbit(sk), function(A) AddSet(extimgs,A);end);
   #add the missing singletons
-  Perform(NonImageSingletons(sk),
-          function(x) Add(imageset,x);end);
-  #now sorting descending by size
-  Sort(imageset,DescendingSizeSorter);
-  return imageset;
+  Perform(NonImageSingletons(sk), function(A) AddSet(extimgs,A);end);
+  return extimgs;
 end);
 
-InstallGlobalFunction(ContainsSet,
-function(sk, set)
-  #checking whether we have the set somewhere
-  return set in ForwardOrbit(sk)
-         or set = BaseSet(sk)
-         or set in NonImageSingletons(sk);
+#just to give a nice descending view of the sets
+InstallGlobalFunction(SortedExtendedImageSet,
+function(sk)
+local sets;
+  sets := ShallowCopy(AsSet(ExtendedImageSet(sk)));
+  Sort(sets,FiniteSetComparator);
+  return sets;
 end);
 
 ################################################################################
@@ -102,7 +90,7 @@ InstallMethod(InclusionCoverRelation,
         "for a skeleton (SgpDec)", [IsSkeleton],
 function(sk)
   return HasseDiagramBinaryRelation(
-          PartialOrderByOrderingFunction(Domain(ExtendedImageSet(sk)),
+          PartialOrderByOrderingFunction(Domain(AsSet(ExtendedImageSet(sk))),
                                          IsSubsetBlist));
 end);
 
@@ -300,7 +288,7 @@ end);
 
 InstallGlobalFunction(TilesOf,
 function(sk,set)
-  if ContainsSet(sk,set) then
+  if set in ExtendedImageSet(sk) then
     return Images(InclusionCoverRelation(sk),set);
   else
     return fail;

lib/skeletongroups.gi

@@ -123,7 +123,7 @@ end);
 InstallGlobalFunction(NontrivialRoundTripWords,
 function(sk,set)
 local roundtrips,rtws,nontrivs;
-  if not ContainsSet(sk,set) then return fail;fi;
+  if not (set in ExtendedImageSet(sk)) then return fail;fi;
   rtws := RoundTripWords(sk,set);
   roundtrips := List(rtws, w->EvalWordInSkeleton(sk,w));
   nontrivs := Filtered([1..Size(roundtrips)],

tst/skeleton.tst

@@ -30,7 +30,7 @@ gap> S := Semigroup(Transformation([5,5,5,5,5]));;
 gap> sk := Skeleton(S);;
 gap> Display(sk);
 <skeleton of Semigroup( [ Transformation( [ 5, 5, 5, 5, 5 ] ) ] )>
-gap> ExtendedImageSet(sk);
+gap> SortedExtendedImageSet(sk);
 [ {1,2,3,4,5}, {1}, {2}, {3}, {4}, {5} ]
 gap> ImageWitness(sk, FiniteSet([1..5]), FiniteSet([5]));
 fail
@@ -62,7 +62,7 @@ gap> Q := FiniteSet([3,4],6);;
 gap> IsSubsetBlist(OnFiniteSet(Q, EvalWordInSkeleton(sk,
 >        SubductionWitness(sk,P,Q))),P);
 true
-gap> ExtendedImageSet(sk);
+gap> SortedExtendedImageSet(sk);
 [ {1,2,3,4,5,6}, {1,2,3,4}, {1,2,3}, {4,5,6}, {1,2}, {1,3}, {1,4}, {2,3}, 
   {2,4}, {3,4}, {4,5}, {4,6}, {5,6}, {1}, {2}, {3}, {4}, {5}, {6} ]
 gap> Interpret(sk, 1,1);
@@ -77,7 +77,7 @@ gap> DominatingChains(sk, [FiniteSet([1],6)]);
   [ {1,2,3,4,5,6}, {1,2,3,4}, {1,2,3}, {1,3}, {1} ], 
   [ {1,2,3,4,5,6}, {1,2,3,4}, {1,4}, {1} ] ]
 gap> sk := Skeleton(Semigroup(Transformation([5,5,5,5,5])));;
-gap> ExtendedImageSet(sk);
+gap> SortedExtendedImageSet(sk);
 [ {1,2,3,4,5}, {1}, {2}, {3}, {4}, {5} ]
 gap> NonImageSingletonClasses(sk);
 [ [ {4} ], [ {3} ], [ {2} ], [ {1} ] ]