Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented correct chaining algorithm; API change; Updated testing. #28

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

thomasgaozx
Copy link
Contributor

No description provided.

@egri-nagy
Copy link
Contributor

The test fails for MaxChainOfEssentialDependency, the output seems to be changed, or debugging message remained.
Please run SgpDecTestInstall(); before commits.

Copy link
Contributor

@egri-nagy egri-nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxChainOfEssentialDependency fails in the tests.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.82%. Comparing base (66ad07f) to head (8153f0c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   96.71%   96.82%   +0.11%     
==========================================
  Files          44       44              
  Lines        3040     3053      +13     
==========================================
+ Hits         2940     2956      +16     
+ Misses        100       97       -3     
Files Coverage Δ
lib/lowerbound.gd 100.00% <100.00%> (ø)
lib/lowerbound.gi 95.40% <95.83%> (+4.86%) ⬆️

@egri-nagy egri-nagy merged commit c230228 into gap-packages:master Jun 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants