Constructors taking Into<String>
#16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't help quite as much as one might hope because there's still lots of structures that you build literally, and those all contain `String` and kind of have to. If you want me to make constructor functions for those I will, but that's an API decision I happily leave up to you.
Basically just boilerplate, as discussed in garritfra#15. This is in its own PR so you can decide separately whether or not you want it. Still need to do for this: * Instr struct * Docstrings * Unit tests?
|
From your ToDo-list I read that you're still working on this PR. I'll convert this to a draft, for clarity. Hope you don't mind! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds various
new()funcs takingInto<String>This is basically just boilerplate, as discussed in #15. This is in its own PR so you can decide separately whether or not you want it. It's not really finished, just intended as a sample for discussion.
Changes proposed in this pull request
new()functions for most/all types so that we can takeInto<String>for names instead of just Strings.ToDo
Still need to do for this:
Instrstruct