Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix those occlusion problems #168

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

EasyVector
Copy link
Contributor

@EasyVector EasyVector commented Sep 2, 2021

Dear developer:

Hello! I am the creator of issue #167, and I have fixed those aforementioned occlusion problems. I would genuinely appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here are the screenshots after my changes. And I would also like to say that in the first screenshot, I want to keep the consistency of size among those names, so I make the longer string end with ellipsises, and I still could know the monster's full name on the corresponding summary page:

copy copy

Thanks again! Blessings on your day! :)

Copy link
Member

@jaysondc jaysondc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Accessibility is always one of those tricky things that's hard to cover unless we spend a lot of time testing. 👍

@jaysondc jaysondc merged commit 2cd97da into gatheringhallstudios:master Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants