Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Conda Windows migration: failing tests in current vcpkg and new conda envs #1088

Open
j-rivero opened this issue Dec 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@j-rivero
Copy link
Contributor

j-rivero commented Dec 3, 2024

The issues tries to compile the current status of failing tests in existing vcpkg and the new conda environments, specially related to the installations of ogre, ogre-next in both. Special focus on reporting problems in current version that are not catched by the testing suite due to different bugs: #1089 and #1090

Fortress (gz-rendering6)

➡️ Reference build https://build.osrfoundation.org/view/gz-fortress/job/gz_rendering-ign-rendering6-win/100

Current status

Although the test suite is green, there are different problems affecting the run:

  • ogre: 1.12.9
    • ✔️ CMake / Configuring time: detected
    • ⚠️ Test suite: not run (bug in hardcoding the engines in test_config.h)
  • ogre-next: 2.1.9999~20210319~3aa42f
    • ✔️ CMake / Configuring time: detected
    • ⚠️ Test suite: run but critical problems seems not to be catched by test suite
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ⚠️ Test suite: run (this is a bug in hardcoding the engines in test_config.h)

Real failures in current

This is a run with the right engine support implemented #1089 and a heavy failure if the engine fails to be loaded #1090 .

➡️ Reference build: https://build.osrfoundation.org/job/gz_rendering-pr-win/266

  • ogre: 1.12.9
    • ✔️ CMake / Configuring time: detected
    • 🔥 Tests suite: run, 26 failing tests
  • ogre-next: 2.1.9999~20210319~3aa42f
    • ✔️ CMake / Configuring time: detected
    • 🔥 Test suite: run, 65 failing tests
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

Conda migration

➡️ Reference build: https://build.osrfoundation.org/view/conda/job/_test_gz_rendering-pr-cwin/24

  • ogre: 1.10.12.1
    • ✔️ CMake / Configuring time: detected
    • 🔥 Tests suite: run, 8 failing tests [ignore the LoadOgre2Test]
  • ogre-next: 2.2.6
    • 🔥 CMake / Configuring time: failed
    • Test suite: disabled
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

Failing tests inspection

test-name output diagnose
UNIT_BoundingBoxCamera_TEST Engine 'ogre' doesn't support bounding box cameras ✅ unsupported. To be disabled
UNIT_RenderEngine_TEST ItemIdentityException: Resource with the name Default/TransRed already exists ⚠️ might be easy to fix
UNIT_Visual_TEST ItemIdentityException: Resource with the name Default/TransRed already exists. ⚠️ might be easy to fix
INTEGRATION_gpu_rays Expected: (14.9) < (range), actual: 14.9 vs 0 🔥 Probably needs deeper debug
INTEGRATION_camera gz-rendering\test\media\materials\programs\simple_color_vs.glsl already exists ⚠️ might be easy to fix
INTEGRATION_render_pass _Distortion already exists. in ResourceManage ⚠️ might be easy to fix
PERFORMANCE_scene_factory ✅ memory check test. To be disabled
@j-rivero j-rivero added the bug Something isn't working label Dec 3, 2024
@j-rivero j-rivero changed the title Conda Windows migration: failing tests in current vcpkg and new conda envs WIP: Conda Windows migration: failing tests in current vcpkg and new conda envs Dec 3, 2024
@azeey azeey moved this from Inbox to In progress in Core development Dec 16, 2024
@Crola1702
Copy link
Contributor

@j-rivero @azeey are the changes used to reproduce this already on production agents?

I see gz-rendering6 is showing the 65 failing tests due to ogre2 not supported

https://build.osrfoundation.org/job/gz_rendering-ign-rendering6-win/113/

@j-rivero
Copy link
Contributor Author

Harmonic (gz-rendering8)

➡️ Reference build https://build.osrfoundation.org/view/gz-harmonic/job/gz_rendering-8-win/117

Current status

69 reported failures

  • 🔥 AWS AMI agent: probably without GPU support
  • ogre: 1.12.9
    • ✔️ CMake / Configuring time: detected
    • ⚠️ Test suite: failing 69 tests. References to Failed to initialize render-engine
  • ogre-next: 2.1.9999~20210319~3aa42f
    • 🔥 CMake / Configuring time: not detected
    • 🔥 Test suite: not run
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

Real failures in current

TODO: run a build of current status in machines with a tested AMI gpu support.

Conda migration

➡️ Reference build: https://build.osrfoundation.org/view/conda/job/gz_rendering-8-cwin/3

  • ✔️ AWS AMI agent: tested GPU dxiag
  • ogre: 1.10.12.1
    • ✔️ CMake / Configuring time: detected
    • 🔥 Many failing tests (don't know the reason)
  • ogre-next: 2.3.3
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

@j-rivero
Copy link
Contributor Author

Ionic (gz-rendering9)

➡️ Reference build https://build.osrfoundation.org/view/gz-ionic/job/gz_rendering-9-win/45/ 70 failures

Current status

70 reported failures

  • ✔️ AWS AMI agent: passing GPU support
  • ogre: 1.12.9
    • ✔️ CMake / Configuring time: detected
    • ⚠️ Test suite: failing 70 tests. References to Failed to initialize render-engine
  • ogre-next: 2.1.9999~20210319~3aa42f
    • 🔥 CMake / Configuring time: not detected
    • 🔥 Test suite: not run
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

Conda migration

➡️ Reference build: https://build.osrfoundation.org/view/conda/job/gz_rendering-9-cwin/3/ 52 failing testes

  • ✔️ AWS AMI agent: tested GPU dxiag
  • ogre: 1.10.12.1
    • ✔️ CMake / Configuring time: detected
    • 🔥 Many failing tests (don't know the reason)
  • ogre-next: 2.3.3
    • ✔️ CMake / Configuring time: failed
    • ✔️ Test suite: almost all passed. One failing (UNIT_RenderingIface_TEST_ogre2_gl3plus)[https://build.osrfoundation.org/view/conda/job/gz_rendering-9-cwin/3/testReport/(root)/UNIT_RenderingIface_TEST_ogre2_gl3plus/test_ran/]
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

@j-rivero
Copy link
Contributor Author

Fortress (ign-rendering6)

Conda migration

➡️ Reference build:

  • ✔️ AWS AMI agent: passing GPU support
  • ogre: 1.10.12.1
    • ✔️ CMake / Configuring time: detected
    • ✔️ not run. Prefer to run ogre-next
  • ogre-next: 2.2.6
    • ✔️ CMake / Configuring time: ok
    • ✔️ Test suite: Enabled
  • optix:
    • ✔️ CMake / Configuring time: not detected (fine, we don't install the support)
    • ✔️ Test suite: not run (fine)

Failing tests inspection

test-name output diagnose
DepthCamera/DepthCameraTest.DepthCameraBoxes/ogre2 Extremely long log of "\depth_camera.cc(314): error: Expected equality of these values:" 🔥
x3 ThermalCamera/ThermalCameraTest tests are exceeded the expected values ⚠️ unsupported?
x2 SceneFactory Memory Leak Unsupported arch ✔️ to be disabled
RenderingIface_TEST Seems to be loading ogre and not ogre-next ✔️ need to backport Harmonic fix probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

2 participants