Fix segmentation camera color id computation with new math::Color clamping behavior (ogre2) #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
gz-sensors caught a crash in in its segmentation camera integration test on github actions. The error msgs reveal that it related to the new color clamping behavior in
gz::math::Color
:The new Color behavior expects the range to be within [0, 1] but we are passing it values of [0, 255].
More info on the crash: the crash was due to infinite recursion. The function tried to compute (recursively) unique color ids but each new generated color gets clamped to the same value
[1, 1, 1]
.To test:
Run the gz-sensors segmentation camera integration test:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.