-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ign-rendering6 ➡️ gz-rendering7 #921
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
…#905) * Calculate camera intrinsics : Refactor gazebosim#700 (gazebosim#755) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #921 +/- ##
==============================================
Coverage 77.22% 77.22%
==============================================
Files 170 170
Lines 14721 14721
==============================================
Hits 11369 11369
Misses 3352 3352 |
@Crola1702 it looks like the windows job started failing on https://build.osrfoundation.org/view/ign-garden/job/ign_rendering-gz-7-win/80/ with no change in the code. There might be something wrong with how the CI machines are configured. Can you look into it? |
This is: #745. It has been happening consistently in the last month. I'll take a look |
AFAIK, we don't have a lot of control over SEH exceptions. I checked on the internet and found a bit of information about those (link) |
Thanks, I'll respond on the other issue. |
➡️ Forward port
Port
ign-rendering6
➡️gz-rendering7
Branch comparison: gz-rendering7...ign-rendering6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)