Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi_lrauv_race example #2111

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix multi_lrauv_race example #2111

merged 1 commit into from
Sep 13, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Sep 1, 2023

Fix the multi_lrauv_race example. In particular I found two issues:

  1. The topic to control the thruster of the vehicles needs to be updated.
  2. I'm not 100% sure about this one but the turbidity generator looks very dark in my machine. Maybe @mabelzhang can confirm if that's the expected behavior. For now I just removed it to visualize a more clear race.

With turbidity:

lrauv_turbidity

No turbidity:

lrauv_no_turbidity

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from mjcarroll as a code owner September 1, 2023 13:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2111 (899dd99) into gz-sim8 (ecc91e8) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 899dd99 differs from pull request most recent head 85ebb67. Consider uploading reports for the commit 85ebb67 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2111      +/-   ##
===========================================
+ Coverage    65.45%   65.47%   +0.01%     
===========================================
  Files          323      323              
  Lines        30699    30699              
===========================================
+ Hits         20095    20100       +5     
+ Misses       10604    10599       -5     

see 2 files with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 1, 2023
@mabelzhang
Copy link
Contributor

Haha, no that's not the expected behavior. Pitch dark very nice for deep sea though.
I've noticed it broken some time back but wasn't sure what changed in the particle emitter interface. Thanks for fixing it!

@iche033
Copy link
Contributor

iche033 commented Sep 8, 2023

ticketed an issue for the particle bug: gazebosim/gz-rendering#902

@azeey azeey merged commit d052491 into gz-sim8 Sep 13, 2023
@azeey azeey deleted the caguero/fix_multi_lrauv_race branch September 13, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants