Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix compiler warning and signedness issue (#401)
* Fix compiler warning and signedness issue This commit fixes a compiler warning I was getting with regard to signed and unsigned types. On line 794 of `Discovery.hh` we use the recvfrom but we use an unsigned int to check if the error is correct or not. By default recvfrom returns an `ssize_t` not a `uint16_t`. It seems a fix for this has landed in garden but has not been backported to citadel or fortress. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Switch to `int64_t` to make m$s$ w1nd0ws happy Rant: At this point I'm not sure that a true C++ compiler and stdlib exist. There is m$s$ C++ thats a different language from GNU C++. Look at all these plebians using windows... Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
- Loading branch information
dcb737f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message in commit a9f5d82 is inappropriate and unprofessional and goes against the core Gazebo values. I did not mean to insult or disparage any users of windows (I myself being one every now and then) or the company behind it. I sincerely apologize for this lapse of judgment and will be more careful in the language used in my future commits.