Merge ign-transport8 ➡️ ign-transport11 #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue #116 Approved-by: Michael Carroll <michael@openrobotics.org> Approved-by: Nate Koenig <natekoenig@gmail.com>
NodeShared: fix line lengths Approved-by: Carlos Agüero <cen.aguero@gmail.com> Approved-by: Louise Poubel <lupoubel@hotmail.com>
Bump default to 9.0.0 Approved-by: Steve Peters <scpeters@osrfoundation.org> Approved-by: Nate Koenig <natekoenig@gmail.com> Approved-by: Louise Poubel <lupoubel@hotmail.com>
…93437199 (pull request #434) configure.bat: use ign-msgs5 for ign-transport9 Approved-by: Louise Poubel <lupoubel@hotmail.com> Approved-by: Addisu Z. Taddese <addisu@openrobotics.org>
Default hwm Approved-by: Carlos Agüero <cen.aguero@gmail.com> Approved-by: Louise Poubel <lupoubel@hotmail.com>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
The ignition redirection headers for the parameters component were not installed. Also fix result.hh. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Suppress some Windows warnings Signed-off-by: Michael Carroll <michael@openrobotics.org> * Suppress more 4251 protobuf warnings Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Fix windows warngigns Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Pass std::function by value to Node::Subscribe Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added a few moves Signed-off-by: Nate Koenig <nate@openrobotics.org> --------- Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Forward port 8 to 11 Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Added Node::RequestRaw Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added example Signed-off-by: Nate Koenig <nate@openrobotics.org> * Code check Signed-off-by: Nate Koenig <nate@openrobotics.org> * Typo Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Checks Signed-off-by: Nate Koenig <nate@openrobotics.org> * Refactor request raw Signed-off-by: Nate Koenig <nate@openrobotics.org> * Address comments Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Carlos Agüero <caguero@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
* Support clang and std::filesystem Signed-off-by: Nate Koenig <natekoenig@gmail.com> * A bit cleaner Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Version v2 of the actions/checkout workflow is deprecated, so switch to v3. Part of gazebo-tooling/release-tools#862. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The LICENSE file contained a copy of the stanze used at the top of source code files, while the actual license was in the COPYING file. So remove the stanza and put the actual Apache 2.0 license text in LICENSE. Similar to gazebosim/gz-math#521. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge ign-transport8 ➡️ ign-transport11
Version v2 of the actions/checkout workflow is deprecated, so switch to v3. Part of gazebo-tooling/release-tools#862. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Fix compiler warning and signedness issue This commit fixes a compiler warning I was getting with regard to signed and unsigned types. On line 794 of `Discovery.hh` we use the recvfrom but we use an unsigned int to check if the error is correct or not. By default recvfrom returns an `ssize_t` not a `uint16_t`. It seems a fix for this has landed in garden but has not been backported to citadel or fortress. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Switch to `int64_t` to make m$s$ w1nd0ws happy Rant: At this point I'm not sure that a true C++ compiler and stdlib exist. There is m$s$ C++ thats a different language from GNU C++. Look at all these plebians using windows... Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge ign-transport8 ➡️ ign-transport11
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
* Consider discovery initialized after two heartbeat cycles Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-transport8➡️ign-transport11Branch comparison: ign-transport11...ign-transport8
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)