fix: force conversion of withdrawal code #449
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix that is probably unnecessary but that I am keeping around in case my analysis is wrong and the fix is indeed needed.
During the overlay transition, withdrawals to unconverted addresses will cause the account to be loaded, but not its code/data. if that is the case, then we have this strange situation where the code is not in the tree but a non-empty code hash refers to it.
this shouldn't be a problem since, as said, fullnodes store the code out of the tree, and so the code will be found as soon as the code hash can be read. nonetheless, the account will be partially translated until the account is converted and so the node commitment will reflect that. this can be surprising to stateless clients, although they should not function during the conversion anyway.