Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force conversion of withdrawal code #449

Draft
wants to merge 1 commit into
base: base-root-last-merkle-root-merge
Choose a base branch
from

Conversation

gballet
Copy link
Owner

@gballet gballet commented Jun 7, 2024

This is a tentative fix that is probably unnecessary but that I am keeping around in case my analysis is wrong and the fix is indeed needed.

During the overlay transition, withdrawals to unconverted addresses will cause the account to be loaded, but not its code/data. if that is the case, then we have this strange situation where the code is not in the tree but a non-empty code hash refers to it.

this shouldn't be a problem since, as said, fullnodes store the code out of the tree, and so the code will be found as soon as the code hash can be read. nonetheless, the account will be partially translated until the account is converted and so the node commitment will reflect that. this can be surprising to stateless clients, although they should not function during the conversion anyway.

@gballet gballet added the wontfix label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant