Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galactic Armada Rewrite - Getting Started #79

Conversation

LaroldsJubilantJunkyard
Copy link
Contributor

Complete rewrite of the galactic armada tutorial. Resetting the fork back to only having the getting started page and the starter code.

@ISSOtm
Copy link
Member

ISSOtm commented Feb 20, 2024

Are you also looking for comments that may significantly alter the subsequent PRs? For example, I'd like to make the Makefile function significantly differently (I can explain why if you'd like me to unroll my rationale), but I'm afraid that'd incur too much work on you in following PRs.

@LaroldsJubilantJunkyard
Copy link
Contributor Author

Are you also looking for comments that may significantly alter the subsequent PRs? For example, I'd like to make the Makefile function significantly differently (I can explain why if you'd like me to unroll my rationale), but I'm afraid that'd incur too much work on you in following PRs.

Well, there's no harm in at least mentioning it. I'll have to factor in the work effort once I know what you're talking about.

@avivace
Copy link
Member

avivace commented Mar 5, 2024

After a constructive conversation with @ISSOtm, we've opted to close those two Pull Requests concerning Part 3.

Instead of continuing with the existing approach, we're embarking on a fresh start. The current Part 3 will remain in the master branch for now. However, we're initiating a comprehensive rewrite, which will be integrated into the master branch , under the label "Part 3 (rewrite)." As this revision progresses and gathers significant content, we plan to phase out the original Part 3, at which point the rewrite will officially take its place.

We'll open a set of initial issues about what needs to be done in the new Part 3, adhering to the existing framework. This strategy will enable the review process to focus on individual code segments (and text parts) one at a time.

@avivace avivace closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants