Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat labels and macros differently in column 1 #1515

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Don't treat labels and macros differently in column 1 #1515

merged 1 commit into from
Sep 22, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Sep 22, 2024 •
edited
Loading

Fixes #1512

This removes the "To invoke Label as a macro it must be indented" error message from #893 since it is no longer applicable.

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Sep 22, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Sep 22, 2024
@Rangi42 Rangi42 requested a review from ISSOtm September 22, 2024 18:31
ISSOtm
ISSOtm approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour one for UX improvements!

I only have a suggestion for the comment attached to this innocuous yet highly load-bearing condition. Let me know if you think that's too verbose :P

src/asm/lexer.cpp Outdated Show resolved Hide resolved
@Rangi42 Rangi42 force-pushed the lexer-hack branch 2 times, most recently from b43ae73 to 936ebba Compare September 22, 2024 20:12
ISSOtm
ISSOtm previously requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, concise is good here.

src/asm/lexer.cpp Outdated Show resolved Hide resolved
src/asm/lexer.cpp Outdated Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from ISSOtm September 22, 2024 20:50
Rangi42
Rangi42 commented Sep 22, 2024
View reviewed changes
man/rgbasm.5 Show resolved Hide resolved
ISSOtm
ISSOtm approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing through with this!

@ISSOtm ISSOtm merged commit 6b89938 into gbdev:master Sep 22, 2024
22 checks passed
@Rangi42 Rangi42 deleted the lexer-hack branch September 22, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Don't treat labels and macros differently in column 1
2 participants
@Rangi42 @ISSOtm