Comment checkdiff output on PRs

[Rangi42]

No description provided.

[Rangi42]

@ISSOtm You mentioned this would be a nice feature; can you look into why it's failing with 403?

[ISSOtm]

I'm guessing that the 403 might be stemming from the wrong endpoint being used? IDRK, this is just a guess. (I used https://octokit.github.io/rest.js/v21/#pulls-create-review as a reference.)

[ISSOtm]

Suggested change

	make checkdiff "BASE_REF=${{ github.event.pull_request.base.sha }}" | tee log
	- name: Comment
	uses: actions/github-script@v7
	with:
	script: |
	github.rest.issues.createComment({
	issue_number: context.issue.number,
	owner: context.repo.owner,
	repo: context.repo.repo,
	body: `**Checkdiff:** <pre><code>${{steps.checkdiff.outputs.response}}</code></pre>`
	})
	make checkdiff "BASE_REF=${{ github.event.pull_request.base.sha }}"
	- name: Comment
	if: ${{ failure() && steps.checkdiff.conclusion == 'failure' }} # Only create the review if `checkdiff` found some errors.
	uses: actions/github-script@v7
	with:
	script: |
	github.rest.pulls.createReview({
	pull_number: context.issue.number,
	owner: context.repo.owner,
	repo: context.repo.repo,
	body: `**Checkdiff:** <pre><code>${{ steps.checkdiff.outputs.response }}</code></pre>`,
	event: "REQUEST_CHANGES",
	})

...and we'd make checkdiff return a non-zero error status if any checks fail?

[Rangi42]

I don't think checkdiff should ever fail that way: false positives are expected sometimes, and CI as a whole shouldn't be marked as ❌ just because of that.

[Rangi42]

Closing this for now, maybe we'll come back to it in the Rust port.