Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape characters in section names in map files #1551

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 22, 2024

With the second commit here, this slightly changes .map file output: a zero-byte section is printed as "($0000 bytes)", instead of "(0 bytes)". This is more consistent with other "($xxxx bytes)" sections, and with the sizes of EMPTY space.

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgblink This affects RGBLINK labels Oct 22, 2024
@Rangi42 Rangi42 requested a review from ISSOtm October 22, 2024 20:29
@Rangi42 Rangi42 force-pushed the map-names branch 2 times, most recently from 3b44756 to df74ff4 Compare October 22, 2024 21:52
This makes size-0 sections print as "($0000 bytes)" instead of
"(0 bytes)", which is more consistent.
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Giving map files some of the love that sym files got.

@ISSOtm ISSOtm merged commit 0d3980d into gbdev:master Oct 23, 2024
22 checks passed
@Rangi42 Rangi42 deleted the map-names branch October 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgblink This affects RGBLINK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants