-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added generic input support for Pandas DataFrames and List Structures #107
base: master
Are you sure you want to change the base?
Conversation
It seems that the failures aren't related to my code as indicated by the node coverage report
Also I've improved the code-quality by removing the two libraries that were not longer needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
is there anything more I need to do on this to get it merged? |
|
||
|
||
# Interface for csv row parsers. | ||
class RowParser(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RowParser class is not used, and it can be removed.
if missing_columns: | ||
raise ValueError('Missing required columns: {}'.format(repr(missing_columns))) | ||
|
||
df = df[self.__columnNames.values()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will prevent extra columns from being included on each bar.
|
Any chance this will be merged in the near future? |
This allows users to easily take advantage of arbitrary data structures as inputs if they are already loaded into memory e.g. for creating custom stressed scenarios
Example