You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've compiled some comments regarding functionality here, not code. Some are probably more on the level of preference and some bugs.
Important: First time the drawer button to the left is clicked it doesn't do anything
Important: Please reuse existing translations. And if you need to introduce new, then also add them to the translation file. Currently there are many that just says search.table.unlockColumn and such
Important: The site footer isn't visible
Important: Using a fixed absolute offset InternalScrollHandler is a fragile approach I suspect. It will likely fail very quickly if anything change. E.g. a user add more filters than what can be in one line. Or we add a warning banner above the header. Or we include the occurrence search on e.g. a collection page. Just see https://demo.gbif-staging.org/occurrence/search?institutionKey=ab8b25c4-f95e-437b-82df-5aed3c9031ec&country=GS&taxonKey=7653835 - the filters disappear under the table on narrower devices
Important: Deleting and adding filters is extremely slow on the table tab, not on the other tabs. So seemingly something in the table view is taking up a lot of resources it seems.
Row heights need more styling. Perhaps a preference. Smaller font? Wider cells? max lines? (see image below)
tiny: Tooltips below table headers (see image below)
Features (little icons with summary data) displays vertically - see image
Important: Changing filters should reset from.
If there is only 1 result it will be styled as one giant full height row with text in the middle. Might be a preference, but personally I find that it looks wrong. (see image)
Important: Array values are not showing correctly. e.g. catalogNumber=RVPO86448-391623 is showing recordedBy as O'Neill, S. SallyFrazer, D.S. Deb instead of as 2 distinct names (each with their own filter) O'Neill, S. Sally,Frazer, D.S. Deb
Important: establishmentMeans values are not showing as formatted labels
Important: Event dates look wrong. data "eventDate": "2017-04-01T00:00Z/2017-04-15T00:00Z" displayed as Apr 1, 2017, 2:00 AM – Apr 15, 2017, 2:00 AM. There is a date formatting component you can use
Other fields with array values like higherGeography also serialise oddly as display value
Important: There seem to be something with columns widths and wrapping that aren't quite working. Some cells are very narrow and very tall. See below
important. On mobile the columns lock is gone, but locked. So you cannot really see anything on the table aside from the first columns.
The scroll to top idea is nice, but doesn't quite work. It will scroll up while loading. And when the content is then loaded it will jump down to mid table. Probably because the size of the rows change when filled with content?
Count header is not translated with localized numbering. you can use the ViewHeader component that is used elsewhere.
Columns not locked on loading
z index of tooltips
Rows very tall
vertical icons
Giant single row
Narrow and tall cells
The text was updated successfully, but these errors were encountered:
I've compiled some comments regarding functionality here, not code. Some are probably more on the level of preference and some bugs.
search.table.unlockColumn
and suchInternalScrollHandler
is a fragile approach I suspect. It will likely fail very quickly if anything change. E.g. a user add more filters than what can be in one line. Or we add a warning banner above the header. Or we include the occurrence search on e.g. a collection page. Just see https://demo.gbif-staging.org/occurrence/search?institutionKey=ab8b25c4-f95e-437b-82df-5aed3c9031ec&country=GS&taxonKey=7653835 - the filters disappear under the table on narrower devicesfrom
.catalogNumber=RVPO86448-391623
is showing recordedBy asO'Neill, S. SallyFrazer, D.S. Deb
instead of as 2 distinct names (each with their own filter)O'Neill, S. Sally
,Frazer, D.S. Deb
establishmentMeans
values are not showing as formatted labels"eventDate": "2017-04-01T00:00Z/2017-04-15T00:00Z"
displayed asApr 1, 2017, 2:00 AM – Apr 15, 2017, 2:00 AM
. There is a date formatting component you can usehigherGeography
also serialise oddly as display valueColumns not locked on loading
z index of tooltips
Rows very tall
vertical icons
Giant single row
Narrow and tall cells
The text was updated successfully, but these errors were encountered: