Requests via httpx
#174
Requests via httpx
#174
Conversation
JR-1991
added
pkg:testing
|
Todo: Add a badge for Python versions supported |
Add supported Python versions
| @@ -1,4 +1,4 @@ | |||
| [](https://pypi.org/project/pyDataverse/)  [](https://coveralls.io/github/gdcc/pyDataverse) [](https://pydataverse.readthedocs.io/en/latest)  [](https://opensource.org/licenses/MIT) [](https://github.com/psf/black) [](https://doi.org/10.5281/zenodo.4664557) | |||
| [](https://pypi.org/project/pyDataverse/)  [](https://coveralls.io/github/gdcc/pyDataverse) [](https://pydataverse.readthedocs.io/en/latest) <img src="https://img.shields.io/badge/python-3.8 | 3.9 | 3.10 | 3.11-blue.svg" alt="PyPI - Python Version"> [](https://opensource.org/licenses/MIT) [](https://github.com/psf/black) [](https://doi.org/10.5281/zenodo.4664557) | |||
There was a problem hiding this comment.
As discussed, I copied this from https://github.com/gdcc/python-dvuploader (but changed the alt text).
I played a bit with a Markdown version...
... but it's squished together and ugly to add %20 for spaces.
It's interesting that the old badge comes from https://img.shields.io/pypi/pyversions/pydataverse.svg . How are those versions set? 🤔 Should we be updating more files?
There was a problem hiding this comment.
Thanks for adding the badge @pdurbin !
True that, both ways do not look perfect. As far as I can recall, adding whitespaces is used by most Python repositories (e.g. pyDantic). Shall we stick to the whitespaces?
It's interesting that the old badge comes from https://img.shields.io/pypi/pyversions/pydataverse.svg . How are those versions set? 🤔 Should we be updating more files?
We dont need to specify the version using this badge. It fetches the latest version found on PyPI and puts it there. Pretty smooth 😁
There was a problem hiding this comment.
As discussed during the https://py.gdcc.io meeting today, tests are passing and we want to add a badge to the README indicating that newer versions of Python are required. I went ahead and added a commit for this and some additional discussion but the PR looks good. Approved!
Overview
As highlighted and discussed in issue #171, the
requestslibrary seems to supply wrong content types, leading to certain upload operations such asreplace_datafilenot working (see the issue for details). This PR addresses this issue and substitutesrequestswithhttpxthat fixes the highlighted problem.Besides the previously mentioned fix, the library also provides means of async requests as shown here. Since async requests were planned anyway, this would inevitably also lead to ditching
requestsand thus the change tohttpxalready paves the way.Changes introduced by this PR
get_request,post_request,put_requestanddelete_requestwithhttpxrequestshttpx>=0.26.0test_file_replacementaddresses an example given in issue problem with replace_datafile #171Additional notes
httpxsupporting Python >3.8, tests for 3.7 had to be removedCloses
Fixes #171