Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation of pyDataverse conda installation (again) #184

Merged
merged 1 commit into from
May 11, 2024

Conversation

PennyHow
Copy link
Contributor

These are minor edits to pyDataverse docs to include documentaion on the new conda install, as discussed here - #159

Platforms

  • OS: NAME, VERSION, 64/32bit
    • Linux 64-bit
  • pyDataverse: VERSION
    • v0.3.1
  • Python: VERSION
    • Python 3.8
  • Dataverse: VERSION
    • NA

Follow best practices

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you followed the guidelines in our Contribution Guide?
  • Have you read the Code of Conduct?
  • Do your changes in a seperate branch. Branches MUST have descriptive names.
  • Have you merged the latest changes from upstream to your branch?

Describe the PR

  • What kind of change does this PR introduce?
    • docs
  • Why is this change required? What problem does it solve?
    • Updating pyDataverse docs with information about how to install the package with conda
  • Screenshots (if appropriate)
  • Put Closes #ISSUE_NUMBER to the end of this pull request

Testing

  • Have you used tox and/or pytest for testing the changes?
  • Did the local testing ran successfully?
  • Did the Continous Integration testing (Travis-CI) ran successfully?

Commits

  • Have descriptive commit messages with a short title (first line).
  • Use the commit message template
  • Put Closes #ISSUE_NUMBER in your commit messages to auto-close the issue that it fixes (if such).

Others

  • Is there anything you need from someone else?
    • If anyone else has anything to add then please do. Also, I added the conda install instructions to the index.rst page as well as the installation page. I know though that you might want to keep the front page simplified and only include the conda install on the installation page (along with the instructions on installing with pipenv). If so, then please feel free to alter accordingly.

Documentation contribution

  • Have you followed NumPy Docstring standard?

Code contribution

  • Have you used pre-commit?
  • Have you formatted your code with black prior to submission (e. g. via pre-commit)?
  • Have you written new tests for your changes?
  • Have you ran mypy on your changes successfully?
  • Have you documented your update (Docstrings and/or Docs)?
  • Do your changes require additional changes to the documentation?

Closes #159

Copy link
Member

@JR-1991 JR-1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for submitting 🙌

@JR-1991 JR-1991 added the pkg:docs Documentation related activities label May 11, 2024
@JR-1991 JR-1991 self-assigned this May 11, 2024
@JR-1991 JR-1991 merged commit 7d63a6d into gdcc:master May 11, 2024
2 checks passed
@JR-1991 JR-1991 added this to the 0.3.3 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:docs Documentation related activities
Projects
Development

Successfully merging this pull request may close these issues.

pyDataverse conda package
2 participants