Added Loader to the Homepage, used Lottie #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-nirvana
requested review from
byt3h3ad,
gdsc-nits,
barnilsarma and
rishinhk004
✅ Deploy Preview for nitshack-7-0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The loader looks good just scale up a bit for mobile view and chcek the design once these is an image in the footer of the loader |
Now the loader footer should be visible
|
@rishinhk004 made the changes. Tell me if I should change the speed of the loader. |
its good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used Lottie file for the sword, I don't know if its good just let me know