Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq page and Team page almost complete. #4

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

Manashgoswamii
Copy link
Collaborator

I am using the json files of NITS Hack 6.0 as dummy datas. also I have removed the root background color property, as it impacts in other pages background properties. Also I have stored the png used in the public folder. I have used z-index property in many places. So when Navbar or other component will complete,then it would may be changed accordingly. This is just the first design, I am ready to make changes according to maintainers advice.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for nitshack-7-0 ready!

Name Link
🔨 Latest commit 3004975
🔍 Latest deploy log https://app.netlify.com/sites/nitshack-7-0/deploys/66fd76526415a200080ec81a
😎 Deploy Preview https://deploy-preview-4--nitshack-7-0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishinhk004
Copy link
Collaborator

Note some changes.

  • Change your pr to dev branch (!important)

  • Make Faq page mobile responsive (to the main div add min ht 100 vh and min width 100 vw)
    Screenshot 2024-10-04 134604

  • The background image of Faq and Team page is not blending with the background color check the design once
    Screenshot 2024-10-04 134946

  • in the card some images are not fully visible try reduce the size of image a bit and make it fit-cover

@rishinhk004 rishinhk004 changed the base branch from main to dev October 4, 2024 17:41
@barnilsarma barnilsarma merged commit 3004975 into gdsc-nits-org:dev Oct 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants